fix: join order rewrite rule #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
added
bugfix
mamcx
reviewed
Feb 21, 2025
Centril
previously requested changes
Feb 21, 2025
joshua-spacetime
force-pushed
the
joshua/fix/planner
branch
from
56521d4 to
6ce8b41
Compare
After swapping the left and right hand sides of a delta join, we were not updating the left and right hand side join fields.
joshua-spacetime
force-pushed
the
joshua/fix/planner
branch
from
b437c03 to
f503417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
After swapping the left and right hand sides of a delta join, we were not updating the left and right hand side join fields.
This resulted in a stack overflow when applying a different rewrite rule for translating named arguments into positional ones.
As part of this patch I also modified the rewrite that stack overflowed to error if an invariant is not met.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Added basic regression test that stack overflowed before this change.
Added an incremental evaluation test similar to the ones we currently have. The current tests we have did not exercise this particular rewrite (left vs right join), and so did not catch this bug.