This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Resource respects field renames in field-errors #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsx
force-pushed
the
test-rename-fields
branch
from
201bbc6 to
72bccec
Compare
tsx
changed the title
tsx
force-pushed
the
test-rename-fields
branch
from
72bccec to
a2bbf1b
Compare
wojcikstefan
commented
Oct 12, 2017
tests/__init__.py
Outdated
| Make sure we can create objects by posting a renamed field consistent | ||
| with Resource#rename_fields. | ||
| """ | ||
| resp = self.app.post('/title_post/', data=json.dumps({ 'title': 'title' })) |
There was a problem hiding this comment.
no need for whitespace between { and }.
flask_mongorest/resources.py
Outdated
| # E.g. if a -> b, b -> c, then a should never be renamed to c. | ||
| fields_to_delete = [] | ||
| fields_to_update = {} | ||
| for k, v in mapping.items(): |
There was a problem hiding this comment.
all the ks and vs in this method could be replaced with more accurate names describing what these variables actually hold.
tsx
force-pushed
the
test-rename-fields
branch
from
a633eb6 to
49d5bf9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more test coverage to the code. Both cleancat and mongoengine validation errors are renamed.
Fixes #3