Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Create TagHandler - Add AddTag(), GetTag(), RemoveTag(), ListTag(), FindTag() and Testing code of them #1243

Merged
merged 11 commits into from
Jul 29, 2024

Conversation

yby654
Copy link
Member

@yby654 yby654 commented Jul 15, 2024

  • Add tagging feature for supported resources
    : VPC, VM, DISK, MYIMAGE, NLB, SG, KEY, CLUSTER

  • Add TagHandler
    : AddTag(), GetTag(), RemoveTag(), ListTag(), FindTag()

  • Add Test Resource code

@powerkimhub powerkimhub self-requested a review July 15, 2024 07:07
@powerkimhub
Copy link
Member

@yby654 @ish-hcc

@ish-hcc
Copy link
Member

ish-hcc commented Jul 26, 2024

@powerkimhub 서세안 선임님이 리소스 별 태깅 테스트 하면서 작업하고 계십니다 리뷰 후에 이어서 PR 올리도록 하겠습니다.

@powerkimhub
Copy link
Member

@ish-hcc

  • 넵. 현황 공유 캄사합니다.

@@ -161,7 +167,7 @@ func (vpcHandler *AzureVPCHandler) GetVPC(vpcIID irs.IID) (irs.VPCInfo, error) {
return irs.VPCInfo{}, getErr
}
LoggingInfo(hiscallInfo, start)

fmt.Printf("vpc : %+v" , vpc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yby654 @ish-hcc

  • 디버깅 코드가 남아 있네요.
  • 점검/삭제 부탁드립니다

@yby654
Copy link
Member Author

yby654 commented Jul 29, 2024

  • 리소스 생성 시 태그 생성 기능 추가
  • 디버깅 코드 제거 완료

@powerkimhub powerkimhub merged commit e671f4a into cloud-barista:master Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants