-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmark names #398
base: master
Are you sure you want to change the base?
Fix benchmark names #398
Conversation
Signed-off-by: Vicente Zepeda Mas <[email protected]>
2c12561
to
a69dc1d
Compare
Fixing systemd analyze image for arm64 Signed-off-by: Vicente Zepeda Mas <[email protected]>
Don't you need to change |
Good catch! |
Signed-off-by: Vicente Zepeda Mas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 15 15
Lines 869 869
=======================================
Hits 342 342
Misses 527 527
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Results for SNAFU CI Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can't find anything missing, but I'll try to do a more thorough double check with grep tomorrow.
@@ -1,11 +1,12 @@ | |||
FROM registry.access.redhat.com/ubi8:latest | |||
|
|||
RUN dnf install -y --nodocs git python3-pip && dnf clean all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intentional here?
Description
Inconsistencies on naming have been having negative effects on our automation on image building.
Fixes
#347