Adds new metadata values

[chentex]

Type of change

• Refactor
• New feature
• Bug fix
• Optimization
• Documentation Update

Description

• Includes FIPS, Publish, and Architecture extraction

Related Tickets & Documents

• Related Issue #
• Closes #

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Testing

• Please describe the System Under Test.
• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

[jtaleric]

Curious, what is Publish?

[chentex]

Curious, what is Publish?

It tells you if the cluster is External or Private facing, I'm open to new names

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (0140b10) to head (6e5e424).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   84.66%   86.06%   +1.40%     
==========================================
  Files           6        6              
  Lines         339      287      -52     
==========================================
- Hits          287      247      -40     
+ Misses         38       26      -12     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rsevilla87]

.

[vishnuchalla]

Curious, what is Publish?

It tells you if the cluster is External or Private facing, I'm open to new names

if its just a bool, can we rename it as isPublic or something?

[rsevilla87]

The current metadata implementation doesn't crash when used on vanilla kubernetes clusters (kind), I wonder if it's possible to follow this strategy with the new fields.

For example, the library was handling the error of the infra object in these lines:

go-commons/ocp-metadata/ocp-metadata.go

Lines 173 to 178 in 0140b10

	if err != nil {
	// If the infrastructure resource is not found we assume this is not an OCP cluster
	if errors.IsNotFound(err) {
	return nil, nil
	}
	return &infraJSON, err

[chentex]

Resolved all the comments.

[rsevilla87]

lgtm,
works in OCP and Vanillla k8s

Vanilla k8s

$ go run main.go  | jq .
{
  "k8sVersion": "v1.29.2",
  "masterNodesCount": 1,
  "totalNodes": 1
}

OCP 4 .12

$ go run main.go  | jq .
{
  "platform": "AWS",
  "clusterType": "self-managed",
  "ocpVersion": "4.14.3",
  "ocpMajorVersion": "4.14",
  "k8sVersion": "v1.27.6+b49f9d1",
  "masterNodesType": "m6i.2xlarge",
  "masterNodesCount": 3,
  "workerNodesCount": 3,
  "totalNodes": 3,
  "sdnType": "OVNKubernetes",
  "clusterName": "ocp-ci-hq68v",
  "region": "us-west-2",
  "publish": "External",
  "workerArch": "amd64",
  "controlPlaneArch": "amd64",
  "ipsecMode": "Disabled"
}