Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise TLS ca/key/cert parameters in URI #45

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

carlhoerberg
Copy link
Member

eg: ?cacertfile=/tmp/ca.pem&certfile=/tmp/cert.pem&keyfile=/tmp/key.pem

?cacertfile=/tmp/ca.pem&certfile=/tmp/cert.pem&keyfile=/tmp/key.pem
@carlhoerberg
Copy link
Member Author

Fixes cloudamqp/lavinmq#741

@carlhoerberg
Copy link
Member Author

carlhoerberg commented Jul 29, 2024

Should we drop the verify_mode constructor parameter? It's still "useful" if a user passes in a boolean for tls parameter, but then why not pass in your own TLS Context with that parameter set? It is just for convience, and we already got so many constructor parameters.

@carlhoerberg carlhoerberg merged commit 1ffc86d into main Jul 30, 2024
3 checks passed
@carlhoerberg carlhoerberg deleted the tls-params branch July 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants