Fixing test for prometheus pr #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re_metrics_collector.erl Co-authored-by: Péter Gömöri <[email protected]>
Make new metrics return on detailed only and adjust some of the help messages.
Co-authored-by: Péter Gömöri <[email protected]>
|
Tests passed. Only error seen is at end-per-group for several metrics but this is something we had already seen on tests for previous versions. |
|
@gomoripeti Please, check out my last commit body where I explain the reason why tests were failing when klishin tried to merge our PR. The metrics specified by the IMO, even though we don't want our metrics to get aggregated and metrics in the |
LoisSotoLopez
force-pushed
the
fixing-test-for-prometheus-pr
branch
from
ac653d7
to
e5961ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.