Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Django 3.0] Adding compatible versions of other libraries according … #1786

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Feb 17, 2021

…to Django==3.0.12

What changes were proposed in this pull request?

Upgrading other packages version as per requirement of Django==3.0.12

How was this patch tested?

Screenshot 2021-02-17 at 10 00 24 PM

@agl29
Copy link
Collaborator Author

agl29 commented Feb 17, 2021

But now, django_babel==0.6.2 is the latest version And it supports only till Django2. SS
Screenshot 2021-02-17 at 10 01 27 PM
You can see this in CI also.

@agl29 agl29 requested a review from romainr February 17, 2021 16:33
Copy link
Contributor

@romainr romainr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We can fix the issues in follow-up when making the Web Sockets GA

@romainr
Copy link
Contributor

romainr commented Feb 18, 2021

ERROR: Cannot install -r /root/repo/desktop/core/requirements.txt (line 11), -r /root/repo/desktop/core/requirements.txt (line 13), -r /root/repo/desktop/core/requirements.txt (line 14), -r /root/repo/desktop/core/requirements.txt (line 7) and Django==3.0.12 because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested Django==3.0.12
channels 3.0.3 depends on Django>=2.2
django-auth-ldap 1.3.0 depends on django>=1.8
django-axes 5.13.0 depends on django>=2.2
django-babel 0.6.2 depends on django<3.0 and >=1.8

To fix this you could try to:

  1. loosen the range of package versions you've specified
  2. remove package versions to allow pip attempt to solve the dependency conflict

@romainr
Copy link
Contributor

romainr commented Feb 18, 2021

Upgrade

django-babel 0.6.2 --> to remove

FYI: could also use one the fork does not work
python-babel/django-babel#49

You can point to a git directly, e.g.

./build/env/bin/pip install  git+https://github.com/gethue/PyHive 

@agl29 agl29 force-pushed the Django3 branch 2 times, most recently from b0a2a14 to 2d7ad95 Compare February 18, 2021 13:17
desktop/core/requirements.txt Show resolved Hide resolved
@agl29
Copy link
Collaborator Author

agl29 commented Feb 18, 2021

======================================================================
ERROR: oozie.tests.TestEditor.test_get_coordinator_parameters
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/repo/build/env/lib/python3.6/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/root/repo/apps/oozie/src/oozie/tests.py", line 1907, in test_get_coordinator_parameters
    coord = create_coordinator(self.wf, self.c, self.user)
  File "/root/repo/apps/oozie/src/oozie/tests.py", line 4026, in create_coordinator
    response = client.get(reverse('oozie:create_coordinator'))
  File "/root/repo/build/env/lib/python3.6/site-packages/django/test/client.py", line 518, in get
    response = super().get(path, data=data, secure=secure, **extra)
  File "/root/repo/build/env/lib/python3.6/site-packages/django/test/client.py", line 346, in get
    **extra,
  File "/root/repo/build/env/lib/python3.6/site-packages/django/test/client.py", line 421, in generic
    return self.request(**r)
  File "/root/repo/build/env/lib/python3.6/site-packages/django/test/client.py", line 496, in request
    raise exc_value
  File "/root/repo/build/env/lib/python3.6/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/root/repo/build/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/root/repo/build/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python3.6/contextlib.py", line 52, in inner
    return func(*args, **kwds)
  File "/root/repo/apps/oozie/src/oozie/decorators.py", line 145, in decorate
    return view_func(request, *args, **kwargs)
TypeError: create_coordinator() got an unexpected keyword argument 'bundle'

For this type of error, I was trying to understand that what changes between python2 and python3 but not found as of now.

@romainr
Copy link
Contributor

romainr commented Feb 18, 2021

Quick hint, seems to come from:

response = client.get(reverse('oozie:create_coordinator'))

@@ -398,7 +398,7 @@ def schedule_workflow(request, workflow):


@check_job_access_permission()
def create_coordinator(request, workflow=None):
def create_coordinator(request, workflow=None, *args, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels kind of invalid but this code should not be used anymore

@agl29 agl29 merged commit 308a29c into master Feb 22, 2021
@agl29 agl29 deleted the Django3 branch February 22, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants