-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pubsub ack must rely on protocol.IsAck #1064
Conversation
Note: I've found an unclosed issue about that so I mentionned the PR is there: #834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also take a look at action item (2) here and update the doc string?
This comment was marked as outdated.
This comment was marked as outdated.
975bf93
to
923d810
Compare
Hi @embano1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit on the comment and +1 on keeping the existing Finish
error handling behavior.
@chapurlatn wanna rebase and address Michael's comment? |
Signed-off-by: Nicolas Chapurlat <[email protected]>
Signed-off-by: Nicolas Chapurlat <[email protected]>
Signed-off-by: Nicolas Chapurlat <[email protected]>
Signed-off-by: Nicolas Chapurlat <[email protected]>
Signed-off-by: Nicolas Chapurlat <[email protected]>
Signed-off-by: Nicolas Chapurlat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@embano1 for the final review/merge
Thank you! |
PUB/SUB Message acking is missing protocol.Result support.
For example, stan seems to properly handle it: https://github.com/cloudevents/sdk-go/blob/main/protocol/stan/v2/message.go#L66.
This PR fixes the issue with related tests.
Old cases supported:
New behaviour: