bound session cache #195
Merged
bound session cache #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When establishing new TLS sessions, servers may send multiple session tickets (RFC8446 4.6.1). hyper-boring caches tickets without placing a limit on how many tickets are cached. This leads to unbounded growth of hyper-boring's cache and leaves clients vulnerable to malicious servers who might send many session tickets to exhaust a client's available memory. This change bounds the cache to a default of 8 tickets.
inikulin
reviewed
Dec 1, 2023
hyper-boring/src/lib.rs
Outdated
| /// | ||
| /// The session cache configuration of `ssl` will be overwritten. Session capacity is per | ||
| /// session key (domain). | ||
| pub fn with_connector_and_capacity( |
There was a problem hiding this comment.
Let's make it future-proof and use settings struct here:
struct HttpsLayerSettings {
session_cache_capacity: usize
}and change this to:
pub fn with_connector_and_settings(...)
There was a problem hiding this comment.
Doing it that way adding a field to HttpsLayerSettings is still a breaking change so it's not really future-proof. We may want a builder instead.
There was a problem hiding this comment.
makes sense, updated!
rushilmehra
approved these changes
Dec 6, 2023
|
I think there was a discussion about what should the default max, but the discussion didn't reach a conclusion. Honestly I think we should just merge it. |
|
I'm in agreement here - let's just merge. |
|
I don't have permissions to do so, so this will need to be handled by someone else. |
|
Merged, thanks @ehaydenr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When establishing new TLS sessions, servers may send multiple session tickets (RFC8446 4.6.1). hyper-boring caches tickets without placing a limit on how many tickets are cached. This leads to unbounded growth of hyper-boring's cache and leaves clients vulnerable to malicious servers who might send many session tickets to exhaust a client's available memory.
This change bounds the cache to a default of 8 tickets.