Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add troubleshooting for server errors #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sterlingwes
Copy link

Found it really hard to get basic info on why I was seeing an error page when I loaded the app. Figure these steps might be useful. Would love any tips on how to get the deployment ID in a nicer way than directing them to guess at UDIDs in the URL bar!

These steps helped me get at the problem caused by #343

@dario-piotrowicz
Copy link
Member

left a few comments regarding tailing, by the way thanks a bunch @sterlingwes 😃

@sterlingwes
Copy link
Author

Updated! hope that works. thanks for the weekend review 🙏🏻

@dario-piotrowicz
Copy link
Member

Updated! hope that works. thanks for the weekend review 🙏🏻

No problem, thank you very much for contributing! 😃

Ready to merge, just one small last thing, could you squash the commits into one? 🙏

@xtuc xtuc requested a review from celso February 27, 2023 13:23
@celso
Copy link
Collaborator

celso commented Feb 27, 2023

Updated! hope that works. thanks for the weekend review 🙏🏻

No problem, thank you very much for contributing! 😃

Ready to merge, just one small last thing, could you squash the commits into one? 🙏

Can you use capital letters and punctionation in the bullets for consistency with the rest of the documentation?

address feedback

try to undo whitespace chg

address punctuation feedback
@sterlingwes
Copy link
Author

You should really consider changing the default to squash on merge so that force pushing on branches during a review isn't necessary

from my other PR:

have you considered changing the default for the repo to squash on merge? That seems to be the standard nowadays since it encourages PRs to be about one thing (leading to one commit on main, but still allowing for granular commits on the branch and not interrupting the review with force pushes) which is a good practice

Also lowers the contribution barrier to entry.. i find myself less enthused about contributing anything substantial to this repo when it's so much back and forth over smol readme changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants