This repository has been archived by the owner on Mar 2, 2019. It is now read-only.
More details for cpi-resource-uniqueness.md #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey voelzmo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
cppforlife
reviewed
Jan 8, 2018
| @@ -16,20 +27,46 @@ Examples: | |||
| - Azure | |||
| - removal of availability sets after all instances are deleted | |||
|
|
|||
| ## Potential resolutions | |||
| All of these resources are unique for an instance group. To avoid locking in the CPI during `create_vm`, we add a new CPI method `create_server_group` that id be called **before** vms for an instance group are created. Additionally, we add a new CPI method `delete_server_group` that is called after all VMs of an instance group have been deleted. | |||
There was a problem hiding this comment.
how about calling it create_vm_group
|
note to self: how does this deal with multi-cpi? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.