Add option --retry-all-errors when downloading go version #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option --retry-all-errors when downloading go version
A short explanation of the proposed change:
Adding option --retry-all-errors to the curl command used to download the go binary
An explanation of the use cases your change solves
Using just the --retry option of curl doesn't make the call stable enough as it would fail to retry in cases of 'Connection reset by peer' when there's an TCP/IP issue while trying to connect to the host, for example. Adding --retry-all-errors option to the --retry [x], would cause retry of the call, no matter what the responce error is. In this concrete case, as the called url is well known (https://buildpacks.cloudfoundry.org/dependencies/go), adding --retry-all-errors would make the call even more resilient.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
develop
branchI have added an integration test