Minor tweaks

- Added additional comments
- Tidied up some parts
- Display endpoint create directly rather than via custom component
- Added new doc to website menu

src/frontend/packages/cloud-foundry/src/features/cf/user-invites/user-invite.service.ts

@@ -143,12 +143,11 @@ export class UserInviteService {
       map(v => v.entity.metadata && v.entity.metadata.userInviteAllowed === 'true')
     );
 
-    this.canConfigure$ = combineLatest([
+    this.canConfigure$ = combineLatest(
       waitForCFPermissions(this.store, this.activeRouteCfOrgSpace.cfGuid),
-      this.store.select('auth'),
-      cfEndpointService.endpoint$
-    ]).pipe(
-      map(([cf, auth, endpoint]) =>
+      this.store.select('auth')
+    ).pipe(
+      map(([cf, auth]) =>
         cf.global.isAdmin &&
         auth.sessionData['plugin-config'] && auth.sessionData['plugin-config'].userInvitationsEnabled === 'true')
     );

src/frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint-cf-step-1/create-endpoint-cf-step-1.component.ts

@@ -1,7 +1,6 @@
 import { AfterContentInit, Component, Input } from '@angular/core';
 import { FormBuilder, FormGroup, Validators } from '@angular/forms';
 import { ActivatedRoute } from '@angular/router';
-import { StratosCurrentUserPermissions } from '../../../../core/permissions/stratos-user-permissions.checker';
 import { Observable } from 'rxjs';
 import { filter, map, pairwise } from 'rxjs/operators';
 
@@ -12,13 +11,14 @@ import {
 } from '../../../../../../store/src/entity-catalog/entity-catalog-entity/entity-catalog-entity';
 import { ActionState } from '../../../../../../store/src/reducers/api-request-reducer/types';
 import { stratosEntityCatalog } from '../../../../../../store/src/stratos-entity-catalog';
+import { StratosCurrentUserPermissions } from '../../../../core/permissions/stratos-user-permissions.checker';
 import { getIdFromRoute } from '../../../../core/utils.service';
 import { IStepperStep, StepOnNextFunction } from '../../../../shared/components/stepper/step/step.component';
+import { SessionService } from '../../../../shared/services/session.service';
 import { SnackBarService } from '../../../../shared/services/snackbar.service';
 import { ConnectEndpointConfig } from '../../connect.service';
 import { getSSOClientRedirectURI } from '../../endpoint-helpers';
-import { SessionService } from '../../../../shared/services/session.service';
-import { CreateEndpointHelperComponent } from '../create-endpoint-helper/create-endpoint-helper.component';
+import { CreateEndpointHelperComponent } from '../create-endpoint-helper';
 
 
 @Component({

src/frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint-helper/create-endpoint-helper.component.ts → src/frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint-helper.ts

@@ -1,21 +1,16 @@
-import { Component } from '@angular/core';
-import { StratosCurrentUserPermissions } from '../../../../core/permissions/stratos-user-permissions.checker';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
 
-import { getFullEndpointApiUrl } from '../../../../../../store/src/endpoint-utils';
-import { stratosEntityCatalog } from '../../../../../../store/src/stratos-entity-catalog';
-import { SessionService } from '../../../../shared/services/session.service';
+import { getFullEndpointApiUrl } from '../../../../../store/src/endpoint-utils';
+import { stratosEntityCatalog } from '../../../../../store/src/stratos-entity-catalog';
+import { StratosCurrentUserPermissions } from '../../../core/permissions/stratos-user-permissions.checker';
+import { SessionService } from '../../../shared/services/session.service';
 
 type EndpointObservable = Observable<{
   names: string[],
   urls: string[],
 }>;
 
-@Component({
-  selector: 'app-create-endpoint-helper',
-  template: ''
-})
 export class CreateEndpointHelperComponent {
 
   overwritePermission: Observable<StratosCurrentUserPermissions[]>;

src/frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint.module.ts

@@ -8,7 +8,6 @@ import { CreateEndpointBaseStepComponent } from './create-endpoint-base-step/cre
 import { CreateEndpointCfStep1Component } from './create-endpoint-cf-step-1/create-endpoint-cf-step-1.component';
 import { CreateEndpointConnectComponent } from './create-endpoint-connect/create-endpoint-connect.component';
 import { CreateEndpointComponent } from './create-endpoint.component';
-import { CreateEndpointHelperComponent } from './create-endpoint-helper/create-endpoint-helper.component';
 
 @NgModule({
   imports: [
@@ -22,14 +21,12 @@ import { CreateEndpointHelperComponent } from './create-endpoint-helper/create-e
     CreateEndpointBaseStepComponent,
     CreateEndpointConnectComponent,
     ConnectEndpointComponent,
-    CreateEndpointHelperComponent
   ],
   exports: [
     CreateEndpointComponent,
     CreateEndpointCfStep1Component,
     CreateEndpointConnectComponent,
     ConnectEndpointComponent,
-    CreateEndpointHelperComponent
   ]
 })
 export class CreateEndpointModule { }

src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts

@@ -1,4 +1,3 @@
-import { isNgTemplate } from '@angular/compiler';
 import { ComponentFactoryResolver, ComponentRef, Injectable, ViewContainerRef } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
 import { Store } from '@ngrx/store';
@@ -16,13 +15,13 @@ import { StratosCurrentUserPermissions } from '../../../../../core/permissions/s
 import {
   ConnectEndpointDialogComponent,
 } from '../../../../../features/endpoints/connect-endpoint-dialog/connect-endpoint-dialog.component';
+import { SessionService } from '../../../../../shared/services/session.service';
 import { SnackBarService } from '../../../../services/snackbar.service';
 import { ConfirmationDialogConfig } from '../../../confirmation-dialog.config';
 import { ConfirmationDialogService } from '../../../confirmation-dialog.service';
 import { createMetaCardMenuItemSeparator } from '../../list-cards/meta-card/meta-card-base/meta-card.component';
 import { IListAction } from '../../list.component.types';
 import { TableCellCustom } from '../../list.types';
-import { SessionService } from '../../../../../shared/services/session.service';
 
 interface EndpointDetailsContainerRefs {
   componentRef: ComponentRef<EndpointListDetailsComponent>;
@@ -111,9 +110,9 @@ export class EndpointListHelper {
         label: 'Disconnect',
         description: ``, // Description depends on console user permission
         createVisible: (row$: Observable<EndpointModel>) => combineLatest([
-            this.currentUserPermissionsService.can(StratosCurrentUserPermissions.EDIT_ADMIN_ENDPOINT),
-            row$
-          ]).pipe(
+          this.currentUserPermissionsService.can(StratosCurrentUserPermissions.EDIT_ADMIN_ENDPOINT),
+          row$
+        ]).pipe(
           map(([isAdmin, row]) => {
             const isConnected = row.connectionStatus === 'connected';
             return isConnected && (!row.system_shared_token || row.system_shared_token && isAdmin);
@@ -142,9 +141,11 @@ export class EndpointListHelper {
             row$
           ]).pipe(
             map(([userEndpointsEnabled, isAdmin, row]) => {
-              if (userEndpointsEnabled && !row.creator.admin && isAdmin){
+              if (userEndpointsEnabled && !row.creator.admin && isAdmin) {
+                // Disable connect for admins if the endpoint was not created by them. Otherwise this could result in an admin connecting to
+                // multiple user endpoints that all have the same url.
                 return false;
-              }else{
+              } else {
                 const endpoint = entityCatalog.getEndpoint(row.cnsi_type, row.sub_type);
                 const ep = endpoint ? endpoint.definition : { unConnectable: false };
                 return !ep.unConnectable && row.connectionStatus === 'disconnected';
@@ -178,9 +179,9 @@ export class EndpointListHelper {
             row$
           ]).pipe(
             map(([userEndpointsEnabled, isAdmin, isEndpointAdmin, row]) => {
-              if (!userEndpointsEnabled || row.creator.admin){
+              if (!userEndpointsEnabled || row.creator.admin) {
                 return isAdmin;
-              }else{
+              } else {
                 return isEndpointAdmin || isAdmin;
               }
             })
@@ -202,9 +203,9 @@ export class EndpointListHelper {
             row$
           ]).pipe(
             map(([userEndpointsEnabled, isAdmin, isEndpointAdmin, row]) => {
-              if (!userEndpointsEnabled || row.creator.admin){
+              if (!userEndpointsEnabled || row.creator.admin) {
                 return isAdmin;
-              }else{
+              } else {
                 return isEndpointAdmin || isAdmin;
               }
             })

src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoints-list-config.service.ts

@@ -1,7 +1,7 @@
-import { Injectable, OnDestroy } from '@angular/core';
+import { Injectable } from '@angular/core';
 import { Store } from '@ngrx/store';
-import { BehaviorSubject, combineLatest, of, Subscription } from 'rxjs';
-import { debounceTime, filter, map } from 'rxjs/operators';
+import { BehaviorSubject, combineLatest, of } from 'rxjs';
+import { debounceTime, filter, first, map } from 'rxjs/operators';
 
 import { ListView } from '../../../../../../../store/src/actions/list.actions';
 import { SetClientFilter } from '../../../../../../../store/src/actions/pagination.actions';
@@ -29,15 +29,14 @@ import { EndpointCardComponent } from './endpoint-card/endpoint-card.component';
 import { EndpointListHelper } from './endpoint-list.helpers';
 import { EndpointsDataSource } from './endpoints-data-source';
 import { TableCellEndpointAddressComponent } from './table-cell-endpoint-address/table-cell-endpoint-address.component';
-import { TableCellEndpointCreatorComponent } from './table-cell-endpoint-creator/table-cell-endpoint-creator.component';
 import { TableCellEndpointDetailsComponent } from './table-cell-endpoint-details/table-cell-endpoint-details.component';
 import { TableCellEndpointNameComponent } from './table-cell-endpoint-name/table-cell-endpoint-name.component';
 import { TableCellEndpointStatusComponent } from './table-cell-endpoint-status/table-cell-endpoint-status.component';
 
 
 
 @Injectable()
-export class EndpointsListConfigService implements IListConfig<EndpointModel>, OnDestroy {
+export class EndpointsListConfigService implements IListConfig<EndpointModel> {
   cardComponent = EndpointCardComponent;
 
   private singleActions: IListAction<EndpointModel>[];
@@ -109,7 +108,6 @@ export class EndpointsListConfigService implements IListConfig<EndpointModel>, O
     filter: 'Filter Endpoints'
   };
   enableTextFilter = true;
-  userEndpointsSubscription: Subscription;
 
   constructor(
     private store: Store<AppState>,
@@ -125,12 +123,14 @@ export class EndpointsListConfigService implements IListConfig<EndpointModel>, O
       (row: EndpointModel) => userFavoriteManager.getFavoriteEndpointFromEntity(row)
     );
     this.columns.push(favoriteCell);
-    this.userEndpointsSubscription = sessionService.userEndpointsNotDisabled().subscribe(enabled => {
-      if (enabled){
+    sessionService.userEndpointsNotDisabled().pipe(first()).subscribe(enabled => {
+      if (enabled) {
         this.columns.splice(4, 0, {
           columnId: 'creator',
           headerCell: () => 'Creator',
-          cellComponent: TableCellEndpointCreatorComponent,
+          cellDefinition: {
+            valuePath: 'creator.name'
+          },
           sort: {
             type: 'sort',
             orderKey: 'creator',
@@ -221,7 +221,4 @@ export class EndpointsListConfigService implements IListConfig<EndpointModel>, O
     }
   }
 
-  ngOnDestroy() {
-    this.userEndpointsSubscription.unsubscribe();
-  }
 }

src/frontend/packages/core/src/shared/shared.module.ts

@@ -119,7 +119,6 @@ import { LongRunningOperationsService } from './services/long-running-op.service
 import { MetricsRangeSelectorService } from './services/metrics-range-selector.service';
 import { SessionService } from './services/session.service';
 import { UserPermissionDirective } from './user-permission.directive';
-import { TableCellEndpointCreatorComponent } from './components/list/list-types/endpoint/table-cell-endpoint-creator/table-cell-endpoint-creator.component';
 
 
 @NgModule({
@@ -222,7 +221,6 @@ import { TableCellEndpointCreatorComponent } from './components/list/list-types/
     CardProgressOverlayComponent,
     MaxListMessageComponent,
     ProfileSettingsComponent,
-    TableCellEndpointCreatorComponent,
   ],
   exports: [
     ApplicationStateIconPipe,

src/frontend/packages/git/src/shared/components/git-registration/git-registration.component.ts

@@ -1,22 +1,24 @@
 import { Component, OnDestroy } from '@angular/core';
 import { FormBuilder, FormGroup, Validators } from '@angular/forms';
 import { ActivatedRoute } from '@angular/router';
+import {
+  CreateEndpointHelperComponent,
+} from 'frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint-helper';
 import { Observable, Subscription } from 'rxjs';
 import { filter, first, map, pairwise } from 'rxjs/operators';
 
-import { SessionService } from '../../../../../core/src/shared/services/session.service';
 import { EndpointsService } from '../../../../../core/src/core/endpoints.service';
 import { getIdFromRoute } from '../../../../../core/src/core/utils.service';
 import { ConnectEndpointConfig } from '../../../../../core/src/features/endpoints/connect.service';
 import { StepOnNextFunction } from '../../../../../core/src/shared/components/stepper/step/step.component';
+import { SessionService } from '../../../../../core/src/shared/services/session.service';
 import { SnackBarService } from '../../../../../core/src/shared/services/snackbar.service';
 import { getFullEndpointApiUrl } from '../../../../../store/src/endpoint-utils';
 import { entityCatalog } from '../../../../../store/src/public-api';
 import { ActionState } from '../../../../../store/src/reducers/api-request-reducer/types';
 import { stratosEntityCatalog } from '../../../../../store/src/stratos-entity-catalog';
 import { GIT_ENDPOINT_SUB_TYPES, GIT_ENDPOINT_TYPE } from '../../../store/git-entity-factory';
 import { GitSCMService } from '../../scm/scm.service';
-import { CreateEndpointHelperComponent } from 'frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint-helper/create-endpoint-helper.component';
 
 interface EndpointSubTypes {
   [subType: string]: GithubTypes;

src/frontend/packages/store/src/types/auth.types.ts

@@ -28,8 +28,17 @@ export enum APIKeysEnabled {
   ALL_USERS = 'all_users'
 }
 export enum UserEndpointsEnabled {
+  /**
+   * No users can see or create their own endpoints. Admins cannot see any previously created user endpoints.
+   */
   DISABLED = 'disabled',
+  /**
+   * No users can see or create their own endpoints. Admins can manage previously created user endpoints
+   */
   ADMIN_ONLY = 'admin_only',
+  /**
+   * Endpoint Admins can see and create their own endpoints. Admins can manage all user endpoints
+   */
   ENABLED = 'enabled'
 }
 export interface SessionDataConfig {