Skip to content

Commit

Permalink
Add comment and clean up code (#4876)
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Quandt <[email protected]>
  • Loading branch information
thquad authored and richard-cox committed Apr 16, 2021
1 parent 0f13b56 commit 9b3fd3e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ export class EndpointListHelper {
label: 'Unregister',
description: 'Remove the endpoint',
createVisible: (row$: Observable<EndpointModel>) => {
// I think if we end up using these often there should be specific create,
// edit, delete style permissions in the stratos permissions checker
return combineLatest([
this.sessionService.userEndpointsNotDisabled(),
this.currentUserPermissionsService.can(StratosCurrentUserPermissions.EDIT_ADMIN_ENDPOINT),
Expand Down
6 changes: 0 additions & 6 deletions src/jetstream/cnsi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -570,12 +570,6 @@ func TestRegisterWithUserEndpointsEnabled(t *testing.T) {

})
})

Convey("with UserEndpointsEnabled=disabled", func() {
Convey("register existing user endpoint", func() {
// todo user endpoints should automatically overwritten?
})
})
})
}

Expand Down

0 comments on commit 9b3fd3e

Please sign in to comment.