Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default scrape port in the spec #154

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

chombium
Copy link
Contributor

Description

The default scrape port in the spec had to be changed as the port 9100 is used by OTel collector.
This is not critical or breaking change as in the ops file and in the cf-deployment the port 53035 is already used

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

@chombium chombium requested a review from a team as a code owner August 16, 2023 09:08
The default scrape port in the spec had to be changed as the port 9100 is used by
OTel collector and the port 53035 is used in the ops file and cf-deployment.
@chombium chombium changed the title Change default scrape port Change default scrape port in the spec Aug 16, 2023
@ctlong ctlong self-assigned this Aug 16, 2023
@rroberts2222 rroberts2222 merged commit 2caec5d into cloudfoundry:main Aug 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants