Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgraded sample project to .NET 8 #371

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

upgraded sample project to .NET 8 #371

wants to merge 5 commits into from

Conversation

arya2004
Copy link

@arya2004 arya2004 commented Oct 4, 2024

Brief Summary of Changes

  • Updated the project to be compatible with .NET 8, resolving outdated dependencies .
  • Updated the documentation to be suited for .NET 8.

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

  • This PR focuses solely on updating the project to .NET 8. No new features are included yet.
  • Additional features (like the image gallery and Cloudinary integration) will be added in subsequently.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@cld-sec
Copy link
Contributor

cld-sec commented Oct 4, 2024 •
edited
Loading

🎉 Snyk hasn't found any issues so far.

✅ security/snyk check is completed. No issues were found. (View Details)

✅ license/snyk check is completed. No issues were found. (View Details)

@arya2004
Copy link
Author

arya2004 commented Oct 4, 2024

I have updated the project to .NET 8, addressing the dependency update requirement. Below are the updates and next steps for my planned contributions:

  • Updated to .NET 8:

  • Basic Gallery with Upload, View, and Editing via Cloudinary:

    • I am planning to implement a basic image gallery where users can:
      • Upload images to Cloudinary.
      • View images in a gallery interface.
      • Edit images (resize, crop, etc.) using Cloudinary's transformation features.
    • The UI will follow the Blazor Quick Start project design.

  • Advanced Use Cases:

    • I’ll add advanced examples showcasing:
      • Cloudinary's image optimization and transformations.
      • Additional media management features (videos, etc.), if relevant.

  • Improved Documentation

Let me know if this plan aligns with the direction of the project. Once approved, I’ll proceed with implementing these features.

@arya2004 arya2004 changed the title upgraded to .NET 8 upgraded sample project to .NET 8 Oct 4, 2024
@const-cloudinary
Copy link
Contributor

@arya2004 The plan sounds great! Feel free to proceed!

const-cloudinary
const-cloudinary requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@const-cloudinary const-cloudinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arya2004 The project looks awesome!

There are some broken links on top right corner, not critical.

Please remove your credentials from:
https://github.com/cloudinary/CloudinaryDotNet/pull/371/files#diff-9d2b1915978abac450213acc4fc09a2b268e3ed4db2bff3126f89a3507df2c4a

And I strongly suggest you to regenerate your access key in admin console, since this one is obviously leaked.

Feel free to proceed with your plan (like adding a better image gallery, or maybe adding support for deleting files ( I uploaded some of my images to your cloud :) )

samples/PhotoAlbum/Pages/Upload.cshtml
<pre><code class="language-csharp">
var uploadParams = new ImageUploadParams()
{
File = new FileDescription('filename.jpg")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
File = new FileDescription('filename.jpg")
File = new FileDescription("filename.jpg")

samples/PhotoAlbum/Pages/Upload.cshtml.cs
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.RazorPages;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using PhotoAlbum.Data;
using UploadResult = PhotoAlbum.Data.UploadResult;
using Markdig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using Markdig;

samples/PhotoAlbum/appsettings.Development.json
"CloudName": "",
"ApiKey": "",
"ApiSecret": "",
"CloudName": "dtxqasgig",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"CloudName": "dtxqasgig",
"CloudName": "",

samples/PhotoAlbum/appsettings.Development.json
"ApiKey": "",
"ApiSecret": "",
"CloudName": "dtxqasgig",
"ApiKey": "533752815973466",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ApiKey": "533752815973466",
"ApiKey": "",

samples/PhotoAlbum/appsettings.Development.json
"ApiSecret": "",
"CloudName": "dtxqasgig",
"ApiKey": "533752815973466",
"ApiSecret": "LkhGjqjO8zQkjbzc2hL1jFDc628",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ApiSecret": "LkhGjqjO8zQkjbzc2hL1jFDc628",
"ApiSecret": "",

@arya2004
Copy link
Author

apologies for the mistake ;(

will prioritize minor refactoring....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-cloudinary const-cloudinary const-cloudinary requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arya2004 @cld-sec @const-cloudinary