feat(alerts): CA cert creation via cert-manager #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #546 Helm `genCA` function led to reconciliation loops in Greenhouse. Signed-off-by: Richard Tief <[email protected]>
|
We need #615 as a prerequisite to test the cert-manager function. |
|
@ibakshay do helm-test incorporate ci/test-values.yaml? |
Yes, as per their documentation. It looks like we need to add the |
Signed-off-by: IB Akshay <[email protected]>
Signed-off-by: Richard Tief <[email protected]>
Signed-off-by: Richard Tief <[email protected]>
Signed-off-by: Richard Tief <[email protected]>
richardtief
force-pushed
the
alerts/refactor-ca-creation
branch
from
fa2a910 to
ca5a3d3
Compare
Signed-off-by: Richard Tief <[email protected]>
Signed-off-by: Richard Tief <[email protected]>
For consecutive Prometheus installations. Signed-off-by: Richard Tief <[email protected]>
richardtief
force-pushed
the
alerts/refactor-ca-creation
branch
from
0abab63 to
73c9902
Compare
ibakshay
reviewed
Feb 13, 2025
Signed-off-by: Richard Tief <[email protected]>
Signed-off-by: Richard Tief <[email protected]>
ibakshay
reviewed
Feb 13, 2025
Co-authored-by: Akshay Iyyadurai Balasundaram <[email protected]>
ibakshay
reviewed
Feb 13, 2025
ibakshay
approved these changes
Feb 13, 2025
olandr
pushed a commit
that referenced
this pull request
Feb 28, 2025
* feat(alerts): CA cert creation via cert-manager fixes #546 Helm `genCA` function led to reconciliation loops in Greenhouse. Signed-off-by: Richard Tief <[email protected]> * fix(alerts): correct formatting in values.yaml for caCert comment Signed-off-by: IB Akshay <[email protected]> * chore(alerts): improve description in values.yaml Signed-off-by: Richard Tief <[email protected]> * chore(alerts): disable certManager for helm-lint and helm-test Signed-off-by: Richard Tief <[email protected]> * chore(alerts): move ci folder into charts/ Signed-off-by: Richard Tief <[email protected]> * chore(alerts): increase versions Signed-off-by: Richard Tief <[email protected]> * chore(alerts): name cert-manager resources like the organisation Signed-off-by: Richard Tief <[email protected]> * chore(alerts): add shared prometheus cert For consecutive Prometheus installations. Signed-off-by: Richard Tief <[email protected]> * docs(alerts): adds cert-manager option values and explaination Signed-off-by: Richard Tief <[email protected]> * chore(alerts): add cert-manager options to plugindefinition Signed-off-by: Richard Tief <[email protected]> * docs(alerts): improve wording Co-authored-by: Akshay Iyyadurai Balasundaram <[email protected]> --------- Signed-off-by: Richard Tief <[email protected]> Signed-off-by: IB Akshay <[email protected]> Co-authored-by: IB Akshay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #546
Helm
genCAfunction led to reconciliation loops in Greenhouse.