Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dex): do not remove org redirects on default oauthclient #955

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

IvoGoman
Copy link
Contributor

@IvoGoman IvoGoman commented Mar 3, 2025

Description

the greenhouse oauth2client is reused for the dashboard it should include all org redirects
the old logic removed any redirects not specified on the greenhouse org

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

the greenhouse oauth2client is reused for the dashboard
it should include all org redirects
the old logic removed any redirects not specified on the greenhouse org
@IvoGoman IvoGoman requested a review from a team as a code owner March 3, 2025 14:22
@IvoGoman IvoGoman merged commit 7355067 into main Mar 3, 2025
21 checks passed
@IvoGoman IvoGoman deleted the fix/redirects branch March 3, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants