-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mr2011/issue 310/issue match ordering #452
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing some documentation about several functions/methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muy bien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to move the entity.DbColumnName
and the entity.Cursor
to the DB layer.
Description
This PR adds ordering for IssueMatches for the following attributes:
Furthermore, a new cursor implementation has been added. Currently, only
IssueMatch
uses the new implementation. Instead of investing time to make the current implementation generic, I simply duplicated the relevant code. Once the cursor is used by all entities, this code duplication will be removed.What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist