Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mr2011/issue 310/issue match ordering #452

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

MR2011
Copy link
Collaborator

@MR2011 MR2011 commented Jan 27, 2025

Description

This PR adds ordering for IssueMatches for the following attributes:

  • PrimaryName
  • TargetRemediationDate
  • ComponentInstance CCRN

Furthermore, a new cursor implementation has been added. Currently, only IssueMatch uses the new implementation. Instead of investing time to make the current implementation generic, I simply duplicated the relevant code. Once the cursor is used by all entities, this code duplication will be removed.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@dorneanu dorneanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing some documentation about several functions/methods.

internal/app/common/pagination_helpers.go Show resolved Hide resolved
internal/entity/cursor.go Outdated Show resolved Hide resolved
docs/ordering.md Outdated Show resolved Hide resolved
docs/cursor.md Show resolved Hide resolved
dorneanu
dorneanu previously approved these changes Feb 5, 2025
Copy link
Collaborator

@dorneanu dorneanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien

Copy link
Collaborator

@drochow drochow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to move the entity.DbColumnName and the entity.Cursor to the DB layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(issueMatch): Ordering and Pagination
3 participants