fix(vendor): Remove excessive URL validation (#1024)

* fix(vendor): Remove excessive URL validation Fixes #1019 * feat(vendor): Add component to error message --------- Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
cloudposse · Feb 9, 2025 · 5ce76d7 · 5ce76d7
1 parent e152a10
commit 5ce76d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/internal/exec/go_getter_utils.go b/internal/exec/go_getter_utils.go
@@ -27,18 +27,13 @@ func ValidateURI(uri string) error {
 	if len(uri) > 2048 {
 		return fmt.Errorf("URI exceeds maximum length of 2048 characters")
 	}
-	// Add more validation as needed
 	// Validate URI format
 	if strings.Contains(uri, "..") {
 		return fmt.Errorf("URI cannot contain path traversal sequences")
 	}
 	if strings.Contains(uri, " ") {
 		return fmt.Errorf("URI cannot contain spaces")
 	}
-	// Validate characters
-	if strings.ContainsAny(uri, "<>|&;$") {
-		return fmt.Errorf("URI contains invalid characters")
-	}
 	// Validate scheme-specific format
 	if strings.HasPrefix(uri, "oci://") {
 		if !strings.Contains(uri[6:], "/") {

diff --git a/internal/exec/vendor_utils.go b/internal/exec/vendor_utils.go
@@ -370,9 +370,9 @@ func ExecuteAtmosVendorInternal(
 			err = ValidateURI(uri)
 			if err != nil {
 				if strings.Contains(uri, "..") {
-					return fmt.Errorf("Invalid URI '%s': %w. Please ensure the source is a valid local path or a properly formatted URI.", uri, err)
+					return fmt.Errorf("invalid URI for component %s: %w: Please ensure the source is a valid local path", s.Component, err)
 				}
-				return err
+				return fmt.Errorf("invalid URI for component %s: %w", s.Component, err)
 			}
 		}