Feat: Better SSH Socket Support via ssh-agent
(Linux Host)
#764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This fixes firing up
ssh-agent
properly by testing two conditions:ssh-add -l &>/dev/null
. If this returns an error of 2, we can't communicate with the agentIf these fail, then restart the ssh-agent
Additionally, only map
SSH_AUTH_SOCK
from a real folder./tmp
will not properly map into docker and results in being unable to access the socket.Finally, if on Linux and using
SSH_AUTH_SOCK
and you are not running as root (an upcoming PR), you have to map the host socket usingsocat
to access the host folder asroot
.why
ssh-agent
functionality is not robust enough (see above)