Merge pull request #49 from cloudposse/refactor-warning

chore: refactor deletion warning message
cloudposse · Dec 6, 2023 · 4603974 · 4603974
2 parents 4f4efc5 + 0f85f92
commit 4603974
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/.github/workflows/test-failed-plan-drift.yml b/.github/workflows/test-failed-plan-drift.yml
@@ -137,8 +137,8 @@ jobs:
             ```hcl
             Error: Invalid function argument
             
-              on main.tf line 10, in locals:
-              10:   failure = var.enable_failure ? file("Failed because failure mode is enabled") : null
+              on main.tf line 16, in locals:
+              16:   failure = var.enable_failure ? file("Failed because failure mode is enabled") : null
                 ├────────────────
                 │ while calling file(path)
             

diff --git a/.github/workflows/test-failed-plan.yml b/.github/workflows/test-failed-plan.yml
@@ -74,7 +74,7 @@ jobs:
           actual: "${{ fromJSON(needs.test.outputs.summary) }}"
           expected: |
             ## Plan Failed for `foobar-fail` in `plat-ue2-sandbox`
-            
+
             <a href="https://cloudposse.com/"><img src="https://cloudposse.com/logo-300x69.svg" width="100px" align="right"/></a>
             
             [![failed](https://shields.io/badge/PLAN-FAILED-ff0000?style=for-the-badge)](#user-content-result-plat-ue2-sandbox-foobar-fail)
@@ -95,8 +95,8 @@ jobs:
             ```hcl
             Error: Invalid function argument
             
-              on main.tf line 10, in locals:
-              10:   failure = var.enable_failure ? file("Failed because failure mode is enabled") : null
+              on main.tf line 16, in locals:
+              16:   failure = var.enable_failure ? file("Failed because failure mode is enabled") : null
                 ├────────────────
                 │ while calling file(path)
             

diff --git a/components/terraform/foobar/main.tf b/components/terraform/foobar/main.tf
@@ -4,8 +4,14 @@ resource "random_id" "foo" {
     seed = "${module.this.id}-${var.example}"
   }
   byte_length = 8
+
+  lifecycle {
+    ignore_changes = [
+      keepers["timestamp"]
+    ]
+  }
 }
 
 locals {
   failure = var.enable_failure ? file("Failed because failure mode is enabled") : null
-}
+}
diff --git a/config/summary.yaml b/config/summary.yaml
@@ -93,8 +93,9 @@ templates:
 
   deletion_warning: |
     {{if .HasDestroy}}
-    ### :warning: Resource Deletion will happen :warning:
-    This plan contains resource delete operation. Please check the plan result very carefully!
+    > [!CAUTION]
+    **Terraform will delete resources!** 
+    This plan contains resource delete operations. Please check the plan result very carefully.
     {{end}}
 
   change_inside_terraform: |