Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save plan to s3 always (except error) #56

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Save plan to s3 always (except error) #56

merged 3 commits into from
Jan 8, 2024

Conversation

goruha
Copy link
Member

@goruha goruha commented Jan 8, 2024

what

  • Save the plan even if there are no changes.
  • Do not compare the stored plan with the current one; just always save the plan to the s3 bucket

why

  • Fix atmos apply workflow errors when there are no changes
  • Remove complexity of the action

@goruha goruha requested review from a team as code owners January 8, 2024 19:18
@goruha goruha requested review from Gowiem and srhopkins January 8, 2024 19:18
@goruha goruha changed the title Save plan always if no error Save plan to s3 always (except error) Jan 8, 2024
@goruha goruha merged commit 6dd7fae into main Jan 8, 2024
46 of 48 checks passed
@goruha goruha deleted the always-update-planfile branch January 8, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goruha @milldr