Implementing the aws_dynamodb_resource_policy resource to allow a user to set the table or stream's resource policy.
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnsense
changed the title
aws_dynamodb_resource_policy resource to allow a user to set the table or stream's resource policy.
milldr
reviewed
Aug 28, 2024
|
/terratest |
|
Uhm.. apparently the tests are failing because there are tables with the same names deployed. |
|
💥 This pull request now has conflicts. Could you fix it @nnsense? 🙏 |
|
Hi guys, I've resolved the conflict, but time has passed and I don't remember if I needed to do anything else to get this merged, can you advise? Thanks :) |
|
/terratest |
|
Hi @Gowiem thanks for running the test, this is still failing for the same reason above, and I don't know what to do about it, the table is deployed only once, or at least it seems so, are those two tables actually still online maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This minor change is to implement the aws_dynamodb_resource_policy resource, to allow a user to set the table or stream's resource policy. Two more variables are added, one for the table policy, the other for the stream. They are implemented separately (even if the resource is the same) to allow the user to set them as separate objects without adding complexity to terraform.
why
It can be useful, if you're implementing DynamoDB as a trigger for example, to set the right policy allowing that