add max_healthy_percentage - option used during instance refresh #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be approved please. |
|
These long waits for PRs and the long waits between releases are reasons why we are moving away from using cloudposse modules. |
|
/terratest |
OpenTofu and Terraform tests are failing with a launch template error. This could be due to numerous reasons, but my assumption is that the AMI does not exist anymore as the previous change was over a year ago. This commit aims to update the AMI to Ubuntu 22.04 in hopes of fixing the failing tests
|
/terratest |
… a launch template error. This could be due to numerous reasons, but my assumption is that the AMI does not exist anymore as the previous change was over a year ago. This commit aims to update the AMI to Ubuntu 22.04 in hopes of fixing the failing tests
|
I apologize for the delay on this. Currently, the tests are failing from an error that is unrelated to your PR, but I am trying to resolve it so that we can get this merged! |
|
/terratest |
|
@goruha After the test account migration, are there any SCPs in place that might affect these tests? |
|
/terratest |
|
/terratest |
milldr
added
minor
|
/terratest |
milldr
approved these changes
Jan 26, 2025
|
These changes were released in v0.41.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This is adding the
max_healthy_percentageoption.This allows the instance refresh to set this value.
min_healthy_percentageis already set as an option.why
The option is currently missing from the terraform module.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#max_healthy_percentage