Enable uploading a public ssh key into the user account

[FlorinAndrei]

what

This PR enables uploading of a public ssh key into the IAM user account. By default the ssh key uploading is disabled.

It also fixes a minor bug where, even when login_profile_enabled = false, the module would still ask for a value for the pgp_key variable.

why

I need ssh keys attached to my IAM user accounts.

references

[Gowiem]

@FlorinAndrei this is looking good, but unfortunately we need to run some automation to pass our tests. Mind doing the following locally, adding + committing the result, and pushing to your branch?

make init
make readme

Thanks!

[FlorinAndrei]

Done, and pushed to the branch.

[Gowiem]

/terratest

[FlorinAndrei]

AFAICT, now it's the automated tests themselves that are failing for some reason (old test environment maybe?).

Please let me know if there's anything I need to do.

[mergify]

💥 This pull request now has conflicts. Could you fix it @FlorinAndrei? 🙏

[Gowiem]

/terratest

[Gowiem]

@FlorinAndrei we're getting this failure in our tests:

TestExamplesComplete 2024-09-24T14:41:19Z retry.go:72: terraform [output -no-color user_name]
TestExamplesComplete 2024-09-24T14:41:19Z command.go:53: Running command terraform with args [output -no-color user_name]
TestExamplesComplete 2024-09-24T14:41:20Z command.go:121: "cp-testing-user"
    examples_complete_test.go:33: 
        	Error Trace:	examples_complete_test.go:33
        	Error:      	Not equal: 
        	            	expected: "cp-testing-user"
        	            	actual  : "\"cp-testing-user\""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-cp-testing-user
        	            	+"cp-testing-user"
        	Test:       	TestExamplesComplete

Can you look into that? It seems we're double quoting or doing something odd with the username?

[FlorinAndrei]

@Gowiem That doesn't seem related. My changes only refer to the ssh key resource.