-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support multi range #160
base: develop
Are you sure you want to change the base?
Feat: support multi range #160
Conversation
fix:fix bug fix: remove useless code fix: lint code
a04a151
to
a30bed6
Compare
Has this pr finished? Maybe you can fix ci first. |
yeah, this has been finished, i will fix it this weekend, by the way, i have also pull it to the fasthttp valyala/fasthttp#1398 |
finished @Duslia |
Codecov ReportBase: 67.25% // Head: 66.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #160 +/- ##
===========================================
- Coverage 67.25% 66.28% -0.97%
===========================================
Files 89 89
Lines 8578 8952 +374
===========================================
+ Hits 5769 5934 +165
- Misses 2448 2641 +193
- Partials 361 377 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What type of PR is this?
feat
What this PR does / why we need it (English/Chinese):
en:
singlePart
fromfsSmallFileReader
andbigFileReader
bigRangeReader
andsmallRangeReader
, supportsinglePart
andmultiPart
writeTo()
function and case ofmuliRange
ch:
singlePart
从fsSmallFileReader
和bigFileReader
分离bigRangeReader
和smallRangeReader
, 支持singlePart
和multiPart
writeTo()
方法和muliRange
场景的测试Which issue(s) this PR fixes:
#93
addtion
ch:
文档:https://yn9nycbt37.feishu.cn/docx/doxcnKSdKp9cMtjtF3ClkN705Qc
问题:
bigRangeReader
和smallRangeReader
存在较多重复代码,想了很久,不太好统一起来- -