Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playing as a lesser while banished #8159

Closed
cm13-issue-bot opened this issue Jan 19, 2025 · 0 comments · Fixed by #8172
Closed

Playing as a lesser while banished #8159

cm13-issue-bot opened this issue Jan 19, 2025 · 0 comments · Fixed by #8172
Labels
Bug Admin events aren't bugs

Comments

@cm13-issue-bot
Copy link

Testmerges

#7850: 'Acid Runner: Acid gen cap' by TheManWithNoHands at commit 8459e1eaef
#7607: 'Warden Praetorian rework (tm)' by Red-byte3D at commit dfe0d3845b
#8061: 'Revives sunset pr (#6400)' by Git-Nivrak at commit 344b82d847
#7614: 'Loadout Customization - Items expanded & more...' by Zenith00000 at commit 7bfc411369
#7650: 'Yet Another Attempt To Fix Vamp' by ihatethisengine at commit 78dfa03bb5
#8079: 'Moves chempoint gain away from biomatter. Second try.' by TheManWithNoHands at commit 2db59fa138
#8007: 'Frozen's Rat Competition Reward' by realforest2001 at commit e85c527528
#8140: 'WY Goon Tweaks' by realforest2001 at commit 85519264d8

Round ID

25994

Description of the bug

After banishement from hive you cant join it back even as a lesser but by clicking hive core you can rejoin it

What's the difference with what should have happened?

Being notified i cant join

How do we reproduce this bug?

  1. Be banished from hive
  2. Click hive core and join as lesser

Attached logs

N/A

Additional details

  • Author: Raynee403
  • Admin: Lagomorphica
  • Note: None
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Jan 19, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
# About the pull request

This PR ensures all usages of joining as a lesser drone properly does
banishment check. `can_spawn_as_hugger` already does this, but for
whatever reason `can_spawn_as_lesser_drone` did not and instead was only
checked in the verb. I also fixed the incorrect cooldown message since
the cooldown was changed at some point but messages not updated to
reflect the change.

# Explain why it's good for the game

Fixes #8159 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/user-attachments/assets/e67b53ab-10cf-49f2-a316-238ddb904dc1

</details>


# Changelog
:cl: Drathek
fix: Fixed joining as lesser drone not always performing banishment
check
spellcheck: Fixed cooldown message for lesser drone having the wrong
duration
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant