Fixes an exploit that allows you to infinitely stack damage multipliers #8180
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watermelon914
added
Fix
Watermelon914
changed the title
Watermelon914
removed
the
Balance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
As the title says.
Closes #8179
Explain why it's good for the game
Modifying gun damage this way is really buggy and led to a bug (#8179) that lets people stack a damage multiplier infinitely.
A more comprehensive solution would be to, instead, have a gun instance stored in this attachment so that it handles all its own variables, damage multiplers, et cetera, instead of trying to modify the original weapon. This would require an overhaul and is not something I'm opposed to someone doing, but this simple solution should suffice for fixing the exploit.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Fixed an exploit that lets you increase your weapon's damage multiplier infinitely.
/:cl: