Remove legacy ranking code

src/Gameboard.Api/Features/Game/GameController.cs

@@ -244,7 +244,6 @@ public async Task Rerank([FromRoute] string id, CancellationToken cancellationTo
             await Authorize(_permissionsService.Can(PermissionKey.Scores_RegradeAndRerank));
             await Validate(new Entity { Id = id });
 
-            await GameService.ReRank(id);
             await _scoreDenormalization.DenormalizeGame(id, cancellationToken);
             await _mediator.Publish(new GameCacheInvalidateNotification(id), cancellationToken);
         }

src/Gameboard.Api/Features/Game/GameService.cs

@@ -23,7 +23,6 @@ public interface IGameService
     Task<bool> IsUserPlaying(string gameId, string userId);
     Task<IEnumerable<Game>> List(GameSearchFilter model = null, bool sudo = false);
     Task<GameGroup[]> ListGrouped(GameSearchFilter model, bool sudo);
-    Task ReRank(string id);
     Task<Game> Retrieve(string id, bool accessHidden = true);
     Task<ChallengeSpec[]> RetrieveChallengeSpecs(string id);
     Task<SessionForecast[]> SessionForecast(string id);
@@ -213,34 +212,6 @@ public async Task UpdateImage(string id, string type, string filename)
         await _store.SaveUpdate(entity, default);
     }
 
-    public async Task ReRank(string id)
-    {
-        var players = await _store
-            .WithTracking<Data.Player>()
-            .Where(p => p.GameId == id && p.Mode == PlayerMode.Competition)
-            .OrderByDescending(p => p.Score)
-            .ThenBy(p => p.Time)
-            .ThenByDescending(p => p.CorrectCount)
-            .ThenByDescending(p => p.PartialCount)
-            .ToArrayAsync()
-        ;
-
-        int rank = 0;
-        string last = "";
-        foreach (var player in players)
-        {
-            if (player.TeamId != last)
-            {
-                rank += 1;
-                last = player.TeamId;
-            }
-
-            player.Rank = rank;
-        }
-
-        await _store.SaveUpdateRange(players);
-    }
-
     public Task<bool> IsUserPlaying(string gameId, string userId)
         => _store.AnyAsync<Data.Player>(p => p.GameId == gameId && p.UserId == userId, CancellationToken.None);
 

src/Gameboard.Api/Features/Teams/Notifications/TeamSessionResetNotification.cs

@@ -1,26 +1,18 @@
 using System.Threading;
 using System.Threading.Tasks;
-using Gameboard.Api.Services;
+using Gameboard.Api.Features.Scores;
 using MediatR;
 
 namespace Gameboard.Api.Features.Teams;
 
 public record TeamSessionResetNotification(string GameId, string TeamId) : INotification;
 
-internal class TeamSessionResetHandler : INotificationHandler<TeamSessionResetNotification>
+internal class TeamSessionResetHandler(IScoreDenormalizationService scoreDenorm) : INotificationHandler<TeamSessionResetNotification>
 {
-    private readonly GameService _gameService;
-
-    public TeamSessionResetHandler
-    (
-        GameService gameService
-    )
-    {
-        _gameService = gameService;
-    }
+    private readonly IScoreDenormalizationService _scoreDenorm = scoreDenorm;
 
     public async Task Handle(TeamSessionResetNotification notification, CancellationToken cancellationToken)
     {
-        await _gameService.ReRank(notification.GameId);
+        await _scoreDenorm.DenormalizeGame(notification.GameId, cancellationToken);
     }
 }