Cleanup and bump external game admin to 30 sec refresh.

cmu-sei · Nov 21, 2023 · 49393da · 49393da
1 parent 5bc1261
commit 49393da
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/...ameboard-ui/src/app/admin/components/external-game-admin/external-game-admin.component.ts b/...ameboard-ui/src/app/admin/components/external-game-admin/external-game-admin.component.ts
@@ -54,7 +54,7 @@ export interface ExternalGameAdminContext {
   styleUrls: ['./external-game-admin.component.scss']
 })
 export class ExternalGameAdminComponent implements OnInit {
-  private autoUpdateInterval = 60000;
+  private autoUpdateInterval = 15000;
   private forceRefresh$ = new Subject<void>();
 
   protected ctx$?: Observable<ExternalGameAdminContext>;

diff --git a/...i/src/app/game/pages/external-game-loading-page/external-game-loading-page.component.html b/...i/src/app/game/pages/external-game-loading-page/external-game-loading-page.component.html
@@ -3,7 +3,7 @@
     <div class="page-container page-width mt-5 d-flex flex-column align-items-center justify-content-center">
         <app-error-div [errors]="errors" *ngIf="errors.length"></app-error-div>
         <ng-container *ngIf="!errors.length">
-            <div *ngIf="!launchCompleted">
+            <div *ngIf="!launchCompleted" class="text-center">
                 <h3>Launching</h3>
                 <h1>{{gameLaunchCtx.game.name}}</h1>
             </div>

diff --git a/...-ui/src/app/game/pages/external-game-loading-page/external-game-loading-page.component.ts b/...-ui/src/app/game/pages/external-game-loading-page/external-game-loading-page.component.ts
@@ -71,6 +71,7 @@ export class ExternalGameLoadingPageComponent implements OnInit {
 
     if (player.userId != localUserId) {
       this.log.logError("Can't start game - the playerId does not belong to the currently-authenticated user.");
+      return;
     }
 
     this.titleService.set(`Starting "${game.name}"...`);
-Original file line number
+Diff line change
@@ Expand Up @@
         if (player.userId != localUserId) {
           this.log.logError("Can't start game - the playerId does not belong to the currently-authenticated user.");
+          return;
         }
         this.titleService.set(`Starting "${game.name}"...`);
@@ Expand Down @@