Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CNCF information below hero for takeovers #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thetwopct
Copy link
Collaborator

@thetwopct thetwopct commented Jun 16, 2024

When we have previously implemented home page takeovers for events the introduction to CNCF that sits in the hero disappears. This attempts to remedy that by introducing a new section below the hero which can be used whenever new takeovers are used. It reuses existing styles, and any custom styles are encapsulated in the file (home-cncf-about.php).

PR - https://pr-859-cncfci.pantheonsite.io

Screenshot-2024-06-16 --13 15 00

@cjyabraham
Copy link
Collaborator

I like the idea. I'm not sure about the blog image since it can't really compete with the hero above it. What about using a Phippy character in that space? Maybe Phippy himself?

@thetwopct
Copy link
Collaborator Author

The blob in my thinking connected the homepage to the blobs on other pages (which I never felt it did before)

The picture could definitely improve this was the first I found in our library (the blob shape is auto-applied)

But happy to look at all options. I felt it needed something on that right side as its a bit empty otherwise.

@cjyabraham
Copy link
Collaborator

Let's keep this open for when we do the takeover for Kubecon NA #831

@cjyabraham cjyabraham mentioned this pull request Jul 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants