-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tw] Use a more common translation for "Cloud Native" in Traditional Chinese #2283
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @johnlinp Thanks for your PR. As a soft reminder, for the label https://github.com/cncf/glossary/blob/main/CODEOWNERS#L73-L75 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@johnlinp ,Thanks for your contribution, according to After reviewing the contents, the following files have been synchronized upstream in English,LGTM.
The content of these two documents, because the English upstream has been updated, so they are not fully synchronized.
It is suggested that the above two files should not be updated in this PR, and the PR should be submitted separately so that the review can focus |
af49f56
to
e20f2d3
Compare
@ydFu Thank you for telling me this! I've removed the files you mentioned from my PR, and updated my commit message accordingly. Please see if it looks ok to you. Thanks. |
e20f2d3
to
6d4a5f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thank.
@seokho-son |
This PR didn't update the translation for Cloud Native in these files, because these files are not sync with the latest English version: - content/zh-tw/style-guide/_index.md - content/zh-tw/_index.md Separate PR should be submitted for the above files. Signed-off-by: John Lin <[email protected]>
6d4a5f3
to
53016ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! sorry for this late response.
Describe your changes
Currently, the translation for "Cloud Native" in Traditional Chinese is "雲原生". However, another translation "雲端原生" is more common and makes more sense in Taiwan.
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.