Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Use a more common translation for "Cloud Native" in Traditional Chinese #2283

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

johnlinp
Copy link
Collaborator

Describe your changes

Currently, the translation for "Cloud Native" in Traditional Chinese is "雲原生". However, another translation "雲端原生" is more common and makes more sense in Taiwan.

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 53016ca
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64e33d9a8284c80008c53f10
😎 Deploy Preview https://deploy-preview-2283--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Aug 10, 2023
@pichuang
Copy link
Contributor

Hi @johnlinp Thanks for your PR. As a soft reminder, for the label dev-twreviewer section, you only need to assign the ID of the following files, and we will track them on a weekly basis.

https://github.com/cncf/glossary/blob/main/CODEOWNERS#L73-L75

Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seokho-son
Copy link
Collaborator

Hi @ydFu
Could you check and approve this PR?

Then, I will merge this PR on behalf of the Traditional Chinese approvers (@pichuang @ydFu)

@ydFu
Copy link
Collaborator

ydFu commented Aug 15, 2023

@johnlinp ,Thanks for your contribution, according to #glossary-localization-traditional-chinese in slack,
It is necessary to convert Cloud native to 雲端原生.

After reviewing the contents, the following files have been synchronized upstream in English,LGTM.

config.toml 
content/zh-tw/cloud-native-tech.md 
content/zh-tw/cluster.md 
content/zh-tw/contribute/_index.md 
content/zh-tw/contributor-ladder/_index.md 

The content of these two documents, because the English upstream has been updated, so they are not fully synchronized.
The content of this change will make future updates unable to use the dev-tw branch to compare the change time of the main branch and then track it.

content/zh-tw/style-guide/_index.md 
content/zh-tw/_index.md

It is suggested that the above two files should not be updated in this PR, and the PR should be submitted separately so that the review can focus

cc @seokho-son @pichuang

@johnlinp
Copy link
Collaborator Author

@ydFu Thank you for telling me this! I've removed the files you mentioned from my PR, and updated my commit message accordingly. Please see if it looks ok to you. Thanks.

@ydFu ydFu changed the title Use a more common translation for "Cloud Native" in Traditional Chinese [tw] Use a more common translation for "Cloud Native" in Traditional Chinese Aug 16, 2023
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thank.

@ydFu
Copy link
Collaborator

ydFu commented Aug 16, 2023

Hi @ydFu Could you check and approve this PR?

Then, I will merge this PR on behalf of the Traditional Chinese approvers (@pichuang @ydFu)

@seokho-son
The Traditional Chinese content has been approved,thanks.

This PR didn't update the translation for Cloud Native in these files,
because these files are not sync with the latest English version:

- content/zh-tw/style-guide/_index.md
- content/zh-tw/_index.md

Separate PR should be submitted for the above files.

Signed-off-by: John Lin <[email protected]>
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! sorry for this late response.

@seokho-son seokho-son merged commit 2fc8ee3 into cncf:dev-tw Sep 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
Development

Successfully merging this pull request may close these issues.

5 participants