-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fr] Enable link checking, and normalize links, add missing #3197
[fr] Enable link checking, and normalize links, add missing #3197
Conversation
chalin
commented
Jun 13, 2024
•
edited
Loading
edited
- Contributes to Enable link checking (paths) across languages #3190
- Normalizes links, adding a trailing slash, as reported by the link checker
- Adds a missing link to the containerization page -- so as to match the English base language version of the page
- There are no other changes. Paragraphs were line-wrapped à la Prettier.
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
51ce323
to
9eb1e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, with the caveat that I don't read French very well. Given that these are just link updates, I feel I can help review them.
The link updates are correct.
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
9eb1e48
to
6e177e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chalin Thank you for your support.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nate-double-u - what is the process here? How many approvals are required? |
We can't merge into main. If you change the target branch from main to dev-fr we'll have the rights to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. and Let me merge this PR on behalf of French approvals.