Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Updates (second_path & relocate flatcar) #4114

Merged
merged 17 commits into from
Nov 4, 2024

Conversation

mrbobbytables
Copy link
Member

Dedupes projects that are located in multiple categories and switches them to using second_path.

Moves flatcar to Platform category so that it is accounted for on the website correctly.

Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Copy link

github-actions bot commented Nov 3, 2024

You can preview your changes by visiting this link.

Note

This feature is still experimental and may not work as expected in some cases. Please report any issues you find!

@mrbobbytables
Copy link
Member Author

ah woops, thought I go tall of the ones that need deduping - there are a few others. Let me take care of those before this PR gets merged

@mrbobbytables
Copy link
Member Author

theres a lot more to dedupe than I thought, so this will have to be a first pass for now - important one fixed is flatcar

cc @caniszczyk @cjyabraham @tegioz

Copy link
Contributor

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrbobbytables!

This is great and it will solve some issues 💯

landscape.yml Outdated Show resolved Hide resolved
@tegioz
Copy link
Contributor

tegioz commented Nov 4, 2024

We could also add an entry to the PR template to encourage folks to review if any of the items they'd like to add already exists, and use the second path approach when applicable instead of duplicating.

This should only be used when duplicating items for a different group (i.e. Serverless, Wasm, etc), not to add the same item to multiple categories in the same group (something we'll need to keep an eye on while reviewing PRs).

Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
Signed-off-by: Bob Killen <[email protected]>
@mrbobbytables
Copy link
Member Author

Agreed re:PR template, should update that with some other general things like adding other repos etc.

@caniszczyk caniszczyk added this pull request to the merge queue Nov 4, 2024
Merged via the queue into cncf:master with commit 9a45287 Nov 4, 2024
3 checks passed
@mrbobbytables mrbobbytables deleted the updates branch November 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants