Fix bug, isNullable is not being set from Attribute

cnizzardini · Oct 2, 2024 · 3a3b191 · 3a3b191
1 parent 491ffec
commit 3a3b191
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/Lib/Attribute/AbstractSchemaProperty.php b/src/Lib/Attribute/AbstractSchemaProperty.php
@@ -91,7 +91,8 @@ public function create(): SchemaProperty
             ->setReadOnly($this->isReadOnly)
             ->setWriteOnly($this->isWriteOnly)
             ->setRequired($this->isRequired)
-            ->setEnum($this->enum ?? []);
+            ->setEnum($this->enum ?? [])
+            ->setNullable($this->isNullable);
 
         if ($schemaProperty->getType() === 'array') {
             $schemaProperty->setItems($this->items ?? []);

diff --git a/tests/TestCase/Lib/Attribute/OpenApiSchemaPropertyTest.php b/tests/TestCase/Lib/Attribute/OpenApiSchemaPropertyTest.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace SwaggerBake\Test\TestCase\Lib\Attribute;
 
@@ -20,4 +21,10 @@ public function test_type_array(): void
         $property = (new OpenApiSchemaProperty(name: 'test', type: 'array', items: ['type' => 'object']))->create();
         $this->assertEquals(['type' => 'object'], $property->getItems());
     }
-}
+
+    public function test_is_nullable(): void
+    {
+        $property = (new OpenApiSchemaProperty(name: 'test', type: 'string', isNullable: true))->create();
+        $this->assertTrue($property->isNullable());
+    }
+}