Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login/session creation #142

Merged
merged 25 commits into from
Apr 4, 2019
Merged

Login/session creation #142

merged 25 commits into from
Apr 4, 2019

Conversation

whois-jon-peterson
Copy link
Collaborator

Closes #109
Closes #110
Closes #111
Closes #112
Closes #116

Note: controllers were rendering 404 file, but not giving 404 status. Added status, and moved shared logic to ApplicationController.

Copy link
Collaborator

@wipegup wipegup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change with the 404s

@Vjp888
Copy link
Collaborator

Vjp888 commented Apr 4, 2019

I approve for merge.

@cnodland cnodland merged commit bfae0f7 into master Apr 4, 2019
@cnodland cnodland deleted the user_login branch April 4, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants