Admin upgrade downgrade users #56 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the correct page
…the merchant page for admin
…ted with that merchant as well as downgrading the merchant
…a user is redirected to the correct uri if their role is a user
wipegup
reviewed
Apr 8, 2019
| @@ -13,4 +16,19 @@ def update | |||
| merchant.save | |||
| redirect_to admin_merchants_path | |||
| end | |||
|
|
|||
| def downgrade | |||
There was a problem hiding this comment.
This all looks good, however, for a re-factor we might make downgrade and upgrade into a more RESTful update.
Nothing that should block a merge though
wipegup
approved these changes
Apr 8, 2019
whois-jon-peterson
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Agreed with @wipegup remarks on update vs downgrade/upgrade
cnodland
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for an admin to upgrade and downgrade users from merchant to user and vice versa.
Also adds the ability for the admin to be redirected if they enter in the incorrect URI.
If they enter '/admin/users/:id' but the ID is of a merchant they are redirected to the admin merchant path. This is also the case for a user in the merchants URI
All tests passing
closes #56
closes #55
closes #54
closes #53