Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add swagger annotation, exception handling controller->service #34

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

ssoheeh
Copy link
Collaborator

@ssoheeh ssoheeh commented Jan 25, 2025

Features

Chore

  • oauth controller swagger annotation 추가
  • exception handling controller -> service layer 에서 처리

@ssoheeh ssoheeh requested a review from Zerohertz as a code owner January 25, 2025 06:54
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 2.38095% with 41 lines in your changes missing coverage. Please review.

Project coverage is 24.86%. Comparing base (0720497) to head (c254410).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...server/domain/oauth/service/OAuthLoginService.java 2.85% 34 Missing ⚠️
.../domain/oauth/controller/OAuthLoginController.java 0.00% 7 Missing ⚠️
@@            Coverage Diff            @@
##               main      #34   +/-   ##
=========================================
  Coverage     24.86%   24.86%           
- Complexity       39       40    +1     
=========================================
  Files            38       39    +1     
  Lines           362      366    +4     
  Branches         18       17    -1     
=========================================
+ Hits             90       91    +1     
- Misses          272      275    +3     
Components Coverage Δ
user ∅ <ø> (∅)
Files with missing lines Coverage Δ Complexity Δ
.../domain/oauth/controller/OAuthLoginController.java 7.14% <0.00%> (+4.92%) 1.00 <0.00> (ø)
...server/domain/oauth/service/OAuthLoginService.java 2.85% <2.85%> (ø) 1.00 <1.00> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058584e...c254410. Read the comment docs.

@Zerohertz Zerohertz merged commit b120ccd into main Jan 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: user & oauth
2 participants