Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PycodestyleBear: Process whole output #2904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

areebbeigh
Copy link
Member

This commit modifies process_output to
process all the detected problems instead
of just the first one.

Fixes #2882

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases to check and enforce PycodestyleBear processes whole output? That would be good ^^

@areebbeigh
Copy link
Member Author

Can you add test cases to check and enforce PycodestyleBear processes whole output? That would be good ^^

Done.

@areebbeigh areebbeigh changed the title Process whole output PycodestyleBear: Process whole output Apr 19, 2019
Copy link
Contributor

@KVGarg KVGarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespaces in PycodestyleBearTest.py file. Please check Travis CI build log for more information. https://travis-ci.org/coala/coala-bears/jobs/522021385#L5994
Please run coala before pushing changes!

tests/python/PycodestyleBearTest.py Outdated Show resolved Hide resolved
tests/python/PycodestyleBearTest.py Outdated Show resolved Hide resolved
@areebbeigh areebbeigh force-pushed the issue-2882 branch 2 times, most recently from de7d25c to 8bd8fff Compare April 19, 2019 08:32
@bkhanale
Copy link
Member

bkhanale commented May 21, 2019

@areebbeigh Did the tests pass locally, I'm having some trouble running the tests.

nvm

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase

This commit modifies process_output to
process all the detected problems instead
of just the first one.

Fixes coala#2882
@areebbeigh
Copy link
Member Author

needs a rebase

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

PycodestyleBear always exits with only one result
5 participants