Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2304: GitCommitBearTest.py : Typo in line 50 #2989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msrijita18
Copy link

@msrijita18 msrijita18 commented Apr 3, 2021

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@msrijita18 msrijita18 changed the title Fixed #2304 Fixed issue #2304: GitCommitBearTest.py : Typo in line 50 Apr 3, 2021
@virresh
Copy link
Member

virresh commented Apr 3, 2021

Hi @msrijita18
You might want to go through commit guidelines (http://coala.io/commit) once.
We have three portions in a commit message, the shortlog, body and issue reference. Your commit is missing the first two
Please fix and ammend this PR

Feel free to ask for help if you get stuck

@msrijita18
Copy link
Author

Hi @msrijita18
You might want to go through commit guidelines (http://coala.io/commit) once.
We have three portions in a commit message, the shortlog, body and issue reference. Your commit is missing the first two
Please fix and ammend this PR

Feel free to ask for help if you get stuck

Is it fine now? Thanks!

@virresh
Copy link
Member

virresh commented Apr 4, 2021

Please have a look at https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-7-review-process
It explains amending commit messages

All commits in your PR have to follow the guidelines (so there should be no merge commits)
You'd have to rebase your commits

@msrijita18
Copy link
Author

@anshalshukla
Copy link
Contributor

@msrijita18, please squash all your commits into a single commit

@msrijita18
Copy link
Author

@msrijita18, please squash all your commits into a single commit

I have squashed all the commits into a single commit. Is it fine now? Also should I rebase the commit again?
Thanks!

@anshalshukla
Copy link
Contributor

@msrijita18 I don't think that is necessary. @virresh maybe you can merge this now, changes look good to me

Copy link
Contributor

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally change the commit message to GitCommitBearTest.py: Fix typo in line 51, but that's just personal preference. Changes look good, and the commit message meets the guidelines. LGTM 👍

@utkarsh2102 utkarsh2102 mentioned this pull request May 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants