-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #2304: GitCommitBearTest.py : Typo in line 50 #2989
base: master
Are you sure you want to change the base?
Conversation
Hi @msrijita18 Feel free to ask for help if you get stuck |
messgae -> message Closes coala#2304
Is it fine now? Thanks! |
Please have a look at https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-7-review-process All commits in your PR have to follow the guidelines (so there should be no merge commits) |
Is it fine now? I followed this https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-7-review-process and this for rebasing https://api.coala.io/en/latest/Developers/Git_Basics.html#rebasing. |
@msrijita18, please squash all your commits into a single commit |
I have squashed all the commits into a single commit. Is it fine now? Also should I rebase the commit again? |
@msrijita18 I don't think that is necessary. @virresh maybe you can merge this now, changes look good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally change the commit message to GitCommitBearTest.py: Fix typo in line 51
, but that's just personal preference. Changes look good, and the commit message meets the guidelines. LGTM 👍
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!