-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SettingsTest.py: Tests to increase branch coverage #326
base: master
Are you sure you want to change the base?
SettingsTest.py: Tests to increase branch coverage #326
Conversation
Travis tests have failedHey @abhaygupta97, 1st Buildpytest
TravisBuddy Request Identifier: 49d50110-e028-11e8-844b-b98538abb0b8 |
02f2402
to
1c7620d
Compare
Travis tests have failedHey @abhaygupta97, 1st Buildpytest
TravisBuddy Request Identifier: 50797920-e04a-11e8-844b-b98538abb0b8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes in .nocover.yaml
and run moban
to remove the no cover regex from setup.cfg
tests/generation/SettingsTest.py
Outdated
@@ -51,7 +51,7 @@ def test_write_info(self): | |||
|
|||
def test_allow_complete_section_mode_with_ignore_globs(self): | |||
project_dir = "/repo" | |||
project_files = ['/repo/hello.html'] | |||
project_files = ['/repo/hello.html', '/repo/readme.txt'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#279 (comment) I don't see any change in coverage on removal of that regex. Can you explain the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhaygupta97 I just double checked this and today I could recreate this on python3.5. Also there was another upstream commit in the moban repo to fix something, its quite possible that i was unable to recreate this yesterday because of that. Please rebase and do the changes in .nocover.yaml
accordingly.
the changes look fine
Please re base your branch. I did a fresh installation of quick start and
those weren't the results.
…On Wed 7 Nov, 2018, 5:27 PM abhay gupta ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/generation/SettingsTest.py
<#326 (comment)>
:
> @@ -51,7 +51,7 @@ def test_write_info(self):
def test_allow_complete_section_mode_with_ignore_globs(self):
project_dir = "/repo"
- project_files = ['/repo/hello.html']
+ project_files = ['/repo/hello.html', '/repo/readme.txt']
If the code , '/repo/readme.txt' is removed and pytest is run, coverage
is not 100%. Following is the screenshot for it:
[image: ss]
<https://user-images.githubusercontent.com/15020747/48130238-ff976200-e2b1-11e8-8345-a11ba573dba7.png>
This is becuase if ext in exts: in Utilities.py does not have 100%
coverage.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#326 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AceeIhxkc97NI41RcJxEyLhvxQ2vntOHks5ussrGgaJpZM4YNQqM>
.
|
1c7620d
to
d5222dc
Compare
Travis tests have failedHey @abhaygupta97, 1st Buildpytest
TravisBuddy Request Identifier: a9743af0-e519-11e8-80bf-e932c516df5f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your mobans repo and add another moban sync commit to this PR
d5222dc
to
e372bff
Compare
Travis tests have failedHey @abhaygupta97, 1st Buildpytest
TravisBuddy Request Identifier: e991aca0-e576-11e8-a770-eba6d5b1b61e |
@abhaygupta97 Can you also check why is coverage not 100% on Travis Python 3.4 and possibly put the entire log over here like this too, just to make sure its unrelated to your changes and also to raise further issues. |
and rebase your branch and remove the moban sync commit as this will definitely get merged before yours #329 |
e372bff
to
0b65c33
Compare
Travis tests have failedHey @abhaygupta97, 1st Buildpytest
TravisBuddy Request Identifier: 35506840-e7e1-11e8-ad5c-f14c74a66e2e |
@ishanSrt I tried pytest in my local system but there I get 100% coverage. But in travis, it is not showing 100% coverage for the "coala_quickstart/green_mode/green_mode.py". I am using same version of python as being used in travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have made changes in SettingsTest.py
while your commit shortlog mentions Settings.py
Modifying tests in SettingsTest.py file to increase branch coverage of ``if ext in exts:`` in get_extensions function to 100%. Closes coala#279
0b65c33
to
e33c659
Compare
Travis tests have failedHey @abhaygupta97, 1st Buildpytest
TravisBuddy Request Identifier: a383d3c0-e830-11e8-ad5c-f14c74a66e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jayvdb
@jayvdb The changes made have been approved. Please merge it. Or do you feel I need to make any more changes? |
Please rebase @abhaygupta97 , so we can merge it |
Modifying tests in SettingsTest.py file to increase branch coverage
of
if ext in exts:
in get_extensions function to 100%.Closes #279