Update .travis.yml for CI support #24

kiryteo · 2017-12-30T03:05:09Z

Added 'coala --ci' command to travis.yml file, to import coala into Travis CI build.
Fixes #22

gaocegege · 2017-12-30T03:50:29Z

.travis.yml

@@ -51,6 +51,7 @@ script:
  - sed -i.bak '/bears = GitCommitBear/d' .coafile
  # Server side tests.
  - coverage run $(which behave) ./tests/server.features
+  - run coala --ci


run is not a command, it should be coala --ci, IMO

gaocegege · 2017-12-30T03:51:22Z

And please read http://api.coala.io/en/latest/Developers/Newcomers_Guide.html to follow the convention of our community :-)

kiryteo · 2017-12-30T05:38:24Z

I've changed the command, do check if possible

gaocegege · 2017-12-31T07:15:01Z

@kiryteo

Thanks for your contribution, your code works for me but the commit message could be better: http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

Please refine the commit message and it will help you to be a good contributor :-)

kiryteo · 2017-12-31T07:23:11Z

I've added a little description for the commit, thanks for the guidance.!

gaocegege · 2017-12-31T08:19:35Z

Great! Could you push your commit to review?

kiryteo · 2017-12-31T09:06:26Z

I'll just close this PR and create a new one with all things done rightly.. Is that okay.?

gaocegege · 2017-12-31T09:20:55Z

@kiryteo I don't think so, you could run git reset HEAD~1 in your master branch, and the command will reset your latest commit. Then you could commit the changes again and git push --force to override the commit 2f12bb3

gaocegege · 2017-12-31T09:21:51Z

There is no need to file a new PR since it does the same thing as this one.

kiryteo · 2017-12-31T09:23:58Z

okay, I'll do that soon.

…

On Sun, Dec 31, 2017 at 2:51 PM, Ce Gao ***@***.***> wrote: There is no need to file a new PR since it does the same thing as this one. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ado9ZnxY0nF7asScBWix8sb_OfH5TPCtks5tF1IwgaJpZM4RPfrG> .

kiryteo · 2017-12-31T09:37:24Z

I haven't used git from terminal for this changes.. I've just added the necessary command to my forked repository and made the pull request.

gaocegege · 2017-12-31T09:44:39Z

Well, I think it is better to learn git basics in terminal since it is the basis of our project :-)

kiryteo · 2017-12-31T09:50:02Z

Sure, I'll work on it.

…

On Sun, Dec 31, 2017 at 3:14 PM, Ce Gao ***@***.***> wrote: Well, I think it is better to learn git basics in terminal since it is the basis of our project :-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ado9ZjGageor-5yFHCpC3ffP0dE5frhwks5tF1eIgaJpZM4RPfrG> .

gaocegege · 2017-12-31T10:09:47Z

Go ahead and if you have any question you could ask here or our gitter channel https://gitter.im/coala/coala

kiryteo · 2017-12-31T10:35:03Z

Actually, I asked about this issue on gitter firstly but couldn't get the required response, so I mentioned it directly here. Anyway, I would follow the instructions and do the same.

…

On Sun, Dec 31, 2017 at 3:39 PM, Ce Gao ***@***.***> wrote: Go ahead and if you have any question you could ask here or our gitter channel https://gitter.im/coala/coala — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ado9ZqPcgusQbguE9VFy4vzLvriNo3Cjks5tF11sgaJpZM4RPfrG> .

gaocegege · 2018-03-31T03:16:25Z

Hi @kiryteo

Is there any update?

kiryteo · 2018-03-31T22:05:34Z

@gaocegege I have added the commit for review, please have a look.
Sorry for the delay.

gaocegege · 2018-04-01T02:15:53Z

Hi, please squash the commit and repush, then we could merge it.

kiryteo · 2018-04-02T10:55:14Z

@gaocegege Please do have a look.. I think now it should be okay..

gaocegege · 2018-04-02T12:30:00Z

Hi, @kiryteo

There are two commits now and I think we could squash it to one :)

jayvdb

Squash your commits please, or we close the PR as abandoned.

jayvdb · 2018-05-05T10:47:14Z

ping @kiryteo

travis.yml : Add CI for coala This adds ``coala --ci`` to have CI support for coala Fixes #22

gitmate-bot · 2018-05-05T12:53:35Z

Comment on eff372c.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Updated'

Origin: GitCommitBear, Section: commit.

kiryteo · 2018-05-05T13:09:30Z

@jayvdb I have squashed the commits.

gaocegege · 2018-05-05T13:10:37Z

Please resolve the conflicts 😄

kiryteo · 2018-05-05T13:13:44Z

@gaocegege so should I remove the '- coverage run -a -m unittest discover -s tests' part. my commit conflicts with that..

gaocegege · 2018-05-05T13:23:25Z

You could rebase the master locally and use tools to solve them.

jayvdb

rebase hasnt worked.

I suggest you come onto gitter and ask someone to help you step by step to fix this.

gitmate-bot · 2018-06-01T19:56:48Z

Comment on eff372c.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Updated'

Origin: GitCommitBear, Section: commit.

gitmate-bot · 2018-06-01T19:56:49Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 63.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp362oju65/tests/server.features/steps/jsonrpc_steps.py
+++ b/tmp/tmp362oju65/tests/server.features/steps/jsonrpc_steps.py
@@ -60,7 +60,8 @@
 @given('the JSONRPC2Connection instance')
 def step_impl(context):
     context.f = tempfile.TemporaryFile()
-    context.jsonConn = JSONRPC2Connection(conn=TCPReadWriter(context.f, context.f))
+    context.jsonConn = JSONRPC2Connection(
+        conn=TCPReadWriter(context.f, context.f))
 
 
 @when('I write a request to the JSONRPC2Connection with id')

gitmate-bot · 2018-06-01T19:56:50Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 10.

E501 line too long (82 > 79 characters)

Origin: PycodestyleBear (E501), Section: autopep8.

gitmate-bot · 2018-06-01T19:56:51Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 63.

E501 line too long (83 > 79 characters)

Origin: PycodestyleBear (E501), Section: autopep8.

gitmate-bot · 2018-06-01T19:56:51Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 10.

Line is longer than allowed. (82 > 79)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-06-01T19:56:52Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 63.

Line is longer than allowed. (83 > 79)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-06-01T20:03:28Z

Comment on eff372c.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Updated'

Origin: GitCommitBear, Section: commit.

gitmate-bot · 2018-06-01T20:03:29Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 63.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp362oju65/tests/server.features/steps/jsonrpc_steps.py
+++ b/tmp/tmp362oju65/tests/server.features/steps/jsonrpc_steps.py
@@ -60,7 +60,8 @@
 @given('the JSONRPC2Connection instance')
 def step_impl(context):
     context.f = tempfile.TemporaryFile()
-    context.jsonConn = JSONRPC2Connection(conn=TCPReadWriter(context.f, context.f))
+    context.jsonConn = JSONRPC2Connection(
+        conn=TCPReadWriter(context.f, context.f))
 
 
 @when('I write a request to the JSONRPC2Connection with id')

gitmate-bot · 2018-06-01T20:03:30Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 10.

E501 line too long (82 > 79 characters)

Origin: PycodestyleBear (E501), Section: autopep8.

gitmate-bot · 2018-06-01T20:03:30Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 63.

E501 line too long (83 > 79 characters)

Origin: PycodestyleBear (E501), Section: autopep8.

gitmate-bot · 2018-06-01T20:03:31Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 10.

Line is longer than allowed. (82 > 79)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-06-01T20:03:32Z

Comment on eff372c, file tests/server.features/steps/jsonrpc_steps.py, line 63.

Line is longer than allowed. (83 > 79)

Origin: LineLengthBear, Section: linelength.

kiryteo · 2018-06-01T20:04:45Z

@gaocegege resolved conflict, please have a look.

TravisBuddy · 2018-06-01T20:06:32Z

Travis tests have failed

Hey @kiryteo,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

coala --ci

[WARNING][20:05:18] Implicit 'Default' section inheritance is deprecated. It will be removed soon. To silence this warning remove settings in the 'Default' section from your coafile. You can use dots to specify inheritance: the section 'all.python' will inherit all settings from 'all'.
[WARNING][20:05:18] Section `todos` contain invalid language setting: 'Language `python3` is not a valid language name or not recognized by coala.'
Executing section python...
**** SpaceConsistencyBear [Section <empty> | Severity NORMAL] ****
!    ! Line contains following spacing inconsistencies:
!    ! - No newline at EOF.
[----] /home/travis/build/coala/coala-vs-code/tests/resources/unqualified.py
[++++] /home/travis/build/coala/coala-vs-code/tests/resources/unqualified.py
[   2]   a = 1
[   2]   a = 1
[INFO][20:05:19] Applied 'ShowPatchAction' on 'tests/resources/unqualified.py' from 'SpaceConsistencyBear'.
Executing section autopep8...
**** PEP8Bear [Section <empty> | Severity NORMAL] ****
!    ! The code does not comply to PEP8.
[----] /home/travis/build/coala/coala-vs-code/tests/server.features/steps/coalashim_steps.py
[++++] /home/travis/build/coala/coala-vs-code/tests/server.features/steps/coalashim_steps.py
[  23]     context.path = os.path.join(context.dir, 'tests', 'resources', 'qualified.py')
[  23]     context.path = os.path.join(
[  24]         context.dir, 'tests', 'resources', 'qualified.py')
[INFO][20:05:24] Applied 'ShowPatchAction' on 'tests/server.features/steps/coalashim_steps.py' from 'PEP8Bear'.
**** PEP8Bear [Section <empty> | Severity NORMAL] ****
!    ! The code does not comply to PEP8.
[----] /home/travis/build/coala/coala-vs-code/tests/server.features/steps/coalashim_steps.py
[++++] /home/travis/build/coala/coala-vs-code/tests/server.features/steps/coalashim_steps.py
[  51]     context.path = os.path.join(context.dir, 'tests', 'resources', 'unqualified.py')
[  51]     context.path = os.path.join(
[  52]         context.dir, 'tests', 'resources', 'unqualified.py')
[INFO][20:05:24] Applied 'ShowPatchAction' on 'tests/server.features/steps/coalashim_steps.py' from 'PEP8Bear'.
[WARNING][20:05:24] PycodestyleBear (E501): This result has no patch attached.
[WARNING][20:05:24] PycodestyleBear (E501): This result has no patch attached.

tests/server.features/steps/coalashim_steps.py
[  23] ····context.path·=·os.path.join(context.dir,·'tests',·'resources',·'qualified.py')
**** PycodestyleBear (E501) [Section: autopep8 | Severity: NORMAL] ****
!    ! E501 line too long (82 > 79 characters)

tests/server.features/steps/coalashim_steps.py
[  51] ····context.path·=·os.path.join(context.dir,·'tests',·'resources',·'unqualified.py')
**** PycodestyleBear (E501) [Section: autopep8 | Severity: NORMAL] ****
!    ! E501 line too long (84 > 79 characters)
**** PEP8Bear [Section <empty> | Severity NORMAL] ****
!    ! The code does not comply to PEP8.
[----] /home/travis/build/coala/coala-vs-code/tests/resources/unqualified.py
[++++] /home/travis/build/coala/coala-vs-code/tests/resources/unqualified.py
[   2]   a = 1
[   2]     a = 1
[INFO][20:05:24] Applied 'ShowPatchAction' on 'tests/resources/unqualified.py' from 'PEP8Bear'.
[WARNING][20:05:24] PycodestyleBear (E111): This result has no patch attached.
[WARNING][20:05:24] PycodestyleBear (W292): This result has no patch attached.

tests/resources/unqualified.py
[   2] ··a·=·1
**** PycodestyleBear (E111) [Section: autopep8 | Severity: NORMAL] ****
!    ! E111 indentation is not a multiple of four

tests/resources/unqualified.py
[   2] ··a·=·1
**** PycodestyleBear (W292) [Section: autopep8 | Severity: NORMAL] ****
!    ! W292 no newline at end of file
Executing section linelength...
[WARNING][20:05:25] LineLengthBear: This result has no patch attached.
[WARNING][20:05:25] LineLengthBear: This result has no patch attached.

tests/server.features/steps/coalashim_steps.py
[  23] ····context.path·=·os.path.join(context.dir,·'tests',·'resources',·'qualified.py')
**** LineLengthBear [Section: linelength | Severity: NORMAL] ****
!    ! Line is longer than allowed. (82 > 79)

tests/server.features/steps/coalashim_steps.py
[  51] ····context.path·=·os.path.join(context.dir,·'tests',·'resources',·'unqualified.py')
**** LineLengthBear [Section: linelength | Severity: NORMAL] ****
!    ! Line is longer than allowed. (84 > 79)
Executing section commit...
Executing section yml...
[WARNING][20:05:26] YAMLLintBear: This result has no patch attached.

.travis.yml
[  48] #··#·Integration·tests.
**** YAMLLintBear [Section: yml | Severity: NORMAL] ****
!    ! comment not indented like content (comments-indentation)
Executing section cli...

gaocegege · 2018-06-03T15:22:13Z

I suggest you come onto gitter and ask someone to help you step by step to fix this.

PTAL

jayvdb · 2018-06-09T01:18:56Z

Closed due to inactivity.

gaocegege reviewed Dec 30, 2017

View reviewed changes

jayvdb added the process/wip label Apr 6, 2018

jayvdb suggested changes May 5, 2018

View reviewed changes

Updated .travis.yml for CI support

eff372c

travis.yml : Add CI for coala This adds ``coala --ci`` to have CI support for coala Fixes #22

gitmate-bot added process/pending review size/XS difficulty/newcomer importance/low type/enhancement and removed process/wip labels May 5, 2018

kiryteo changed the title ~~Update .travis.yml~~ Updated .travis.yml for CI support May 5, 2018

kiryteo changed the title ~~Updated .travis.yml for CI support~~ Update .travis.yml for CI support May 5, 2018

jayvdb suggested changes May 6, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels May 6, 2018

gitmate-bot added process/pending review and removed process/wip labels Jun 1, 2018

Merge branch 'master' into master

4f64e88

jayvdb closed this Jun 9, 2018

Update .travis.yml for CI support #24

Update .travis.yml for CI support #24

Conversation

kiryteo commented Dec 30, 2017 • edited Loading

gaocegege Dec 30, 2017

Choose a reason for hiding this comment

gaocegege commented Dec 30, 2017

kiryteo commented Dec 30, 2017

gaocegege commented Dec 31, 2017

kiryteo commented Dec 31, 2017 • edited Loading

gaocegege commented Dec 31, 2017

kiryteo commented Dec 31, 2017

gaocegege commented Dec 31, 2017

gaocegege commented Dec 31, 2017

kiryteo commented Dec 31, 2017 via email

kiryteo commented Dec 31, 2017

gaocegege commented Dec 31, 2017

kiryteo commented Dec 31, 2017 via email

gaocegege commented Dec 31, 2017

kiryteo commented Dec 31, 2017 via email

gaocegege commented Mar 31, 2018

kiryteo commented Mar 31, 2018

gaocegege commented Apr 1, 2018

kiryteo commented Apr 2, 2018

gaocegege commented Apr 2, 2018

jayvdb left a comment

Choose a reason for hiding this comment

jayvdb commented May 5, 2018

gitmate-bot commented May 5, 2018

kiryteo commented May 5, 2018

gaocegege commented May 5, 2018

kiryteo commented May 5, 2018 • edited Loading

gaocegege commented May 5, 2018

jayvdb left a comment

Choose a reason for hiding this comment

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

gitmate-bot commented Jun 1, 2018

kiryteo commented Jun 1, 2018

TravisBuddy commented Jun 1, 2018

Travis tests have failed

3rd Build

gaocegege commented Jun 3, 2018

jayvdb commented Jun 9, 2018

kiryteo commented Dec 30, 2017 •

edited

Loading

kiryteo commented Dec 31, 2017 •

edited

Loading

kiryteo commented May 5, 2018 •

edited

Loading