Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: Enable travis-buddy #551

Merged
merged 1 commit into from
Apr 28, 2018
Merged

Conversation

manankalra
Copy link
Contributor

@manankalra manankalra commented Apr 22, 2018

Related to coala/meta#114

@TravisBuddy
Copy link

Hey @manankalra,
Your changes look good to me!

@manankalra
Copy link
Contributor Author

#551 (comment) kind of comments can be disabled by turning on travis-buddy only if the tests fail.

@@ -11,6 +11,7 @@ script:

notifications:
email: false
webhooks: https://www.travisbuddy.com/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manankalra Looks good. 👍
I also agree with you that adding "on_success: never" should be there as well. Gitmate automatically approves the PR if all CI passes, so there should ideally be no message in that case. 😄

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per review

@manankalra
Copy link
Contributor Author

manankalra commented Apr 26, 2018

@jayvdb

per review

didn't get you

@prnvdixit
Copy link
Member

@manankalra He just meant to add the changes as suggested by me to the PR - No message if all tests pass 😅

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

ack 54b819f

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit 54b819f into coala:master Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants