Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specialized RuntimeRepr instances for Complex and LispArray types. #1362

Merged

Conversation

YarinHeffes
Copy link
Collaborator

@YarinHeffes YarinHeffes commented Jan 16, 2025

This PR enables 1. native LispArrays of LispArrays and 2. types parametrized on native Complex types.

For example,

(coalton (array:make 4 (math:complex 0.0d0 0.0d0)))

returns a (cl:simple-array '(cl:complex cl:double-float) (cl:*)) instead of a cl:vector.

@YarinHeffes YarinHeffes marked this pull request as ready for review January 16, 2025 23:21
Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal nits

library/math/complex.lisp Outdated Show resolved Hide resolved
library/math/complex.lisp Outdated Show resolved Hide resolved
tests/lisparray-tests.lisp Outdated Show resolved Hide resolved
library/math/complex.lisp Outdated Show resolved Hide resolved
@stylewarning stylewarning force-pushed the complex-lisparray-runtimerepr branch from 1fb0238 to 24d0e2a Compare January 17, 2025 00:04
@stylewarning stylewarning enabled auto-merge (squash) January 17, 2025 00:04
@stylewarning stylewarning merged commit 889a533 into coalton-lang:main Jan 17, 2025
25 checks passed
@YarinHeffes YarinHeffes deleted the complex-lisparray-runtimerepr branch January 17, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants