Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON parsing: block unlinking #6

Open
Conaclos opened this issue Nov 13, 2016 · 0 comments
Open

JSON parsing: block unlinking #6

Conaclos opened this issue Nov 13, 2016 · 0 comments
Labels

Comments

@Conaclos
Copy link
Member

Conaclos commented Nov 13, 2016

Severity: Low (current assessment)

Problem

When a block is splited on two nodes or more, each node keep a reference to the same block. This enables to each one to edit it.

The object-to-JSON transformation breaks this single reference into several plain objects.
During the JSON-to-object parsing, a (previously) splited block is then represented by several blocks.

Symptoms

The garbage collection of the splited blocks is compromised.
It is not a severe symptom.

Other symptoms are not detected yet.

Possible fix

Remove the block from the nodes and only retains the base of the block'id.
The block is then modified from the base-to-block mapping in logootsropes.

This also implies to move the code that tests if a block is appendable.
Or, maybe two simple flags (isAppendable, isPrependable) for each node is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant