forked from denoland/rusty_v8
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build V8 to dylibs and link rusty_v8 against those #1
Draft
lucksus
wants to merge
40
commits into
v0.92.0
Choose a base branch
from
v0.92-dll
base: v0.92.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 213dbb9)
Remaining unresolved symbols when building consuming executable:
Project has this in its build.rs: println!("cargo:rustc-link-lib=dylib=c++_chrome");
println!("cargo:rustc-link-lib=dylib=third_party_icu_icui18n");
println!("cargo:rustc-link-lib=dylib=icuuc");
println!("cargo:rustc-link-lib=dylib=third_party_abseil-cpp_absl");
println!("cargo:rustc-link-lib=dylib=v8");
println!("cargo:rustc-link-lib=dylib=v8_libbase");
println!("cargo:rustc-link-lib=dylib=v8_libplatform");
println!("cargo:rustc-link-search=native=/Users/nicolasluck/Coasys/code/rusty_v8/target/release/gn_out"); mentioning all dylibs that were build to gn_out. |
…es in filenames (not working yet)
… of clang_path to avoid problem with spaces in filenames
…handling of clang_path to avoid problem with spaces in filenames" This reverts commit b6b0839.
…rebuilds every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_component_build = true
is the main flag to make V8 build to shared librariesV8_FROM_SOURCE
withtrue
so this fork will have changes to V8 build applied within cargo builds of consuming projects without having to set this flag