Support Mac specific keybinds

[tomasmatus]

fixes: #757

[tomasmatus]

I hope we can find a mac friend to test this 👀

[cockpituous]

This added line is not executed by any test.

[cockpituous]

These 2 added lines are not executed by any test.

[cockpituous]

This added line is not executed by any test.

[jelly]

Coverage complains as it checks both sides of the branch, so isApple is never true so no 💯 code coverage.

[mac2net]

I am a Mac friend. I see you want the keyboard commands tested?
But on what exactly?
I currently only install Cockpit and addons though the repository on to Fedora.
I run Fedora 40, 41 beta and Rawhide in VMs on a Minisforum UM780 XTX (AMD 7840HS)
I guess in order to test this I need to install the development version of Files... and also Cockpit?
How do I do that under the circumstances?
I can test this over the weekend, if that's OK.
I use quite a bit of software related to system management and web development so there are a number of utilities fighting for keyboard shortcuts amongst themselves and with MacOS as well.
Please advise if you want me to proceed.
Cheers Mike

[tomasmatus]

Hello @mac2net thanks for your interest to help me test this!
I'd recommend testing in a fedora-40 VM, maybe even spin up a new one just for this test.
Install cockpit using dnf and probably the developer group just to get build dependencies in.

dnf install cockpit
dnf groupinstall "Development Tools"
dnf install gettext nodejs npm make

pull and checkout to this branch

git clone https://github.com/tomasmatus/cockpit-files.git
cd cockpit-files
git switch mac-keybinds

and then you can follow README.md to build and install

make

make devel-install

Now you should have cockpit and cockpit-files ready so please connect to the webui using your macbook and try all of the keybinds listed in the help menu (the screenshot above). You might need to refresh the page if you had the webui running before installing cockpit-files.

[mac2net]

Hi @tomasmatus
Thanks for the instructions.
Before installing the developer version of Cockpit-files, is it good enough to do a normal DNF remove in order to delete the repository version of it?
Cheers Mike

[tomasmatus]

@mac2net yes, if you already have cockpit-files installed from the repository you can remove it using dnf. Also when you want to uninstall the developer version there is make devel-uninstall.

[mac2net]

Hi @tomasmatus There are issues, mostly to do with visual feedback when navigating around. I compared it with the experience in XFCE accessed via VNC with a Mac app called Jump. There are some issues there too.

I don't do a lot of keyboard stuff inside a web page on the Mac, but the MacOS Finder UI is ingrained in my DNA. If you don't have a Mac you should take a trip to an Apple Store to test this. While it is probably not possible or even desired to reproduce the behaviour of the Finder, it is the starting point for Mac users with Cockpit Files.

There is one conflict with Safari – Command-Shift-L opens the left Tab Manager sidebar and in Firefox nothing happens, probably not allowed. Via VNC Control Shift L works fine