-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sidebar #785
base: main
Are you sure you want to change the base?
Remove sidebar #785
Conversation
I assume this needs some follows up:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
Yes, this was on my list to ask about as it wasn't mentioned in the mockup, makes sense to add it then
will do |
Nneeds a fix to work on smalled screens where cwdInfo at the bottom of the page is wrapped.
Looks great so far! It doesn't seem to update when I select a file, however. (The sidebar did, and I thought the status bar would too. The default is to show the current directory if nothing is selected, but show the details for selected items when things are selected.) |
d128eb7
to
dc0f0ff
Compare
if (cwdInfo === null) { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test.
Rework of layout following mockup in #740