Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sidebar #785

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Conversation

tomasmatus
Copy link
Member

@tomasmatus tomasmatus commented Oct 15, 2024

Rework of layout following mockup in #740

image

@jelly
Copy link
Member

jelly commented Oct 15, 2024

I assume this needs some follows up:

  • allow clicking of permissions in the bottom bar or show a popover? (Or both)

Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue found when I press show hidden files it still shows 4 hidden files. We did this different in the old sidebar.

image

Another issue I think is not showing a tooltip for the modification date of files, we should allow one to see the exact ISO formatted timestamp.

@tomasmatus
Copy link
Member Author

Another issue I think is not showing a tooltip for the modification date of files, we should allow one to see the exact ISO formatted timestamp.

Good idea

allow clicking of permissions in the bottom bar or show a popover?

Yes, this was on my list to ask about as it wasn't mentioned in the mockup, makes sense to add it then

One issue found when I press show hidden files it still shows 4 hidden files. We did this different in the old sidebar.

will do

@tomasmatus
Copy link
Member Author

@garrett This should be ready for a design review. Could you please have a look? Tests are red because I am waiting for #775 after which I'lll fix last remaining test.

@garrett
Copy link
Member

garrett commented Oct 22, 2024

Looks great so far!

It doesn't seem to update when I select a file, however. (The sidebar did, and I thought the status bar would too. The default is to show the current directory if nothing is selected, but show the details for selected items when things are selected.)

Comment on lines +29 to +30
if (cwdInfo === null) {
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants